Fix: Big number pad button size is not justified on small screens #25656
Conversation
melvin-bot
bot
requested review from
parasharrajat
and removed request for
a team
|
@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
The problem with the smaller submit button is that it looks inconsistent with other pages in the App. Check these screenshots. I think we should keep the main button the same as before. @shawnborton thought? 
After the Same main button 
|
|
Wait, why is the button smaller on this screen? I thought we were only making the green button at 40px for this screen when the viewport is very small. |
You denied this in #24603 (comment)
Keypads are only shown on mobile so this issue only affects those platforms. Web never had the problem. So we can either make all the buttons medium on the mobile viewport and leave the web as it is. Or we can only make the keypad medium and main button the same on all devices. |
|
Hmm I did not "deny" anything, I think there is a miscommunication here. But to clarify, we should only make the green button in the payment flow use the 40px height for small height mobile viewports. Let me know if that clarifies things. |
|
Ok. I see. So you mean that not all mobiles will show smaller buttons instead the ones with smaller screens? |
|
If this is the case, @tienifr can you please update the PR to handle that. |
|
Yes exactly, the whole point of that issue was to fix this for small screens like iPhone SE. |
…big-number-pad-size-is-not-justified-on-small-screens
|
@parasharrajat Please take a look. I use Safari on iPhoneSE as the threshold for "extremely small screens", which is 548, round it up I got 550. |
| @@ -59,6 +59,7 @@ const NUM_PAD_VIEW_ID = 'numPadView'; | |||
|
|
|||
| function MoneyRequestAmountForm({amount, currency, isEditing, forwardedRef, onCurrencyButtonPress, onSubmitButtonPress}) { | |||
| const {translate, toLocaleDigit, numberFormat} = useLocalize(); | |||
| const screenHeight = Dimensions.get('window').height; | |||
There was a problem hiding this comment.
let's use useWindowDimensions hook. Can we use isExtraSmallScreenWidth instead of height check?
If not, let move the condition to a const and name it as isExtraSmallHeight.
There was a problem hiding this comment.
Can we use isExtraSmallScreenWidth instead of height check?
Yes, we can. I've updated.
src/components/BigNumberPad.js
Outdated
| @@ -71,6 +71,7 @@ function BigNumberPad(props) { | |||
| return ( | |||
| <Button | |||
| key={column} | |||
| medium | |||
There was a problem hiding this comment.
We need to do the same here and use isExtraSmallScreenWidth
|
Please update screenshots. |
…big-number-pad-size-is-not-justified-on-small-screens
|
Updated! More careful testings make me think that we should check base on |
|
That would make sense to me. |
src/styles/variables.js
Outdated
| @@ -76,6 +76,7 @@ export default { | |||
| emojiLineHeight: 28, | |||
| iouAmountTextSize: 40, | |||
| extraSmallMobileResponsiveWidthBreakpoint: 320, | |||
| extraSmallMobileResponsiveHeightBreakpoint: 550, | |||
There was a problem hiding this comment.
How did we come up with this value?
There was a problem hiding this comment.
I use iPhoneSE view port as the threshold.
There was a problem hiding this comment.
But the iPhone SE viewport height is 667px.
There was a problem hiding this comment.
I'm sorry. Actually it was the screen height when open app on Safari. It was 520, then I rounded up to 550. The page on native app has enough space thus not require medium button size.
Screenshots🔲 iOS / nativeScreen.Recording.2023-08-25.at.1.11.44.PM.mov🔲 iOS / SafariScreen.Recording.2023-08-25.at.12.59.24.PM.mov🔲 MacOS / DesktopScreen.Recording.2023-08-25.at.1.02.34.PM.mov🔲 MacOS / ChromeScreen.Recording.2023-08-25.at.12.59.52.PM.mov🔲 Android / ChromeScreen.Recording.2023-08-25.at.1.00.30.PM.mov🔲 Android / nativeScreen.Recording.2023-08-25.at.7.21.27.PM.mov |
There was a problem hiding this comment.
Reviewer Checklist
- I have verified the author checklist is complete (all boxes are checked off).
- I verified the correct issue is linked in the
### Fixed Issuessection above - I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the
Testssection - I verified the steps for Staging and/or Production testing are in the
QA stepssection - I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I verified the steps for local testing are in the
- I checked that screenshots or videos are included for tests on all platforms
- I included screenshots or videos for tests on all platforms
- I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
- If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
- I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
toggleReportand notonIconClick). - I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g.
myBool && <MyComponent />. - I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to
src/languages/*files and using the translation method - I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the
Waiting for Copylabel for a copy review on the original GH to get the correct copy. - I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in
STYLE.md) were followed
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
- If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
- I verified that this PR follows the guidelines as stated in the Review Guidelines
- I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like
Avatar, I verified the components usingAvatarhave been tested & I retested again) - I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
- I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
- If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a
/** comment above it */ - The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to
thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor) - Any internal methods bound to
thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick) - All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
- If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
- If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e.
StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
- If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
- If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like
Avataris modified, I verified thatAvataris working as expected in all cases) - If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
- If a new page is added, I verified it's using the
ScrollViewcomponent to make it scrollable when more elements are added to the page. - If the
mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps. - I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.
🎀 👀 🎀 C+ reviewed
|
@stitesExpensify Conflicts resolved! Have a look when you have time! |
There was a problem hiding this comment.
LGTM. @mountiny did you want to review this too since you're assigned?
|
@mountiny JK that was a different issue 🤦 |
|
@tienifr looks like theres one more conflict |
…big-number-pad-size-is-not-justified-on-small-screens
|
@stitesExpensify Conflicts resolved! |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/stitesExpensify in version: 1.3.59-0 🚀
|
|
🚀 Deployed to staging by https://github.com/stitesExpensify in version: 1.3.60-0 🚀
|
|
🚀 Deployed to staging by https://github.com/stitesExpensify in version: 1.3.60-0 🚀
|
|
🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.59-5 🚀
|
|
🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.60-3 🚀
|
Details
Big number pad button size is not justified on small screens. This PR sets them to medium size.
Fixed Issues
$ #24603
PROPOSAL: #24603 (comment)
Tests
Offline tests
NA
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Web
Mobile Web - Chrome
Mobile Web - Safari
Desktop
iOS
Android