fixed splash screen slightly jumps before hiding #2594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Beamanator
reviewed
Apr 27, 2021
Beamanator
reviewed
Apr 27, 2021
|
@marcaaron would you mind also checking out these changes related to BootSplash since you added that code recently? |
Dal-Papa
previously approved these changes
Apr 28, 2021
|
@Beamanator Updated. Thanks. |
marcaaron
approved these changes
Apr 28, 2021
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging in version: 1.0.33-1🚀
|
|
🚀 Deployed to production in version: 1.0.39-5🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review @Beamanator.
Details
Previously, We manage to fix this issue by making the status bar translucent from the android theme #2567. but it caused a regression #2577 (comment).
New Solution
Fixed Issues
Fixes #2542Tests / QA Steps
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android
1619546789110.mp4