fix: splash screen slightly jumps #2567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Beamanator
approved these changes
Apr 26, 2021
There was a problem hiding this comment.
Tested and looks great 👍 Thanks @parasharrajat - will wait on one more reviewer before merge
Dal-Papa
approved these changes
Apr 26, 2021
66 tasks
|
@parasharrajat, this PR caused a regression on Android. Reverting this PR here, you'll need to resubmit a new solution to the fixed issue. |
5 tasks
|
🚀 Deployed to production in version: 1.0.39-5🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review @Beamanator
Details
A detailed proposal can be found here #2542 (comment).
Fixed Issues
Fixes #2542Tests / QA Steps
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android
Issue
Screenrecorder-2021-04-26-17-06-57-428.0.mp4
After Fix
1619437872143.mp4