-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[hold for payment 7 May] Loading screen logo slightly shifts up before fading away. #2542
Comments
Triggered auto assignment to @Christinadobrzyn ( |
Testing this on the E.cash mobile app on iOS. I see the same 'shift' as well as line issues with the chats when following the Action Performed steps provided in the OP. RPReplay_Final1619138891.MP4The issue seems closely related to two current Upwork proposals but it's unclear if a fix on the other issues will resolve this issue - https://github.com/Expensify/Expensify/issues/160935 & https://github.com/Expensify/Expensify/issues/157743. |
I think this is ready for Eng to review and consider adding an External label. |
Triggered auto assignment to @NikkiWines ( |
This looks like a good issue for a contractor to work on, adding the |
Triggered auto assignment to @SofiedeVreese ( |
Triggered auto assignment to @Beamanator ( |
Upwork Job Posting: https://www.upwork.com/jobs/~0159158ba1789b3203 |
@SofiedeVreese I have not submitted a proposal on upwork, but I'll post the solution directly here I believe that this line needs to be added to I have not tested it, but I'm pretty sure it'll resolve the issue. |
Proposal
Change above to <resources>
<!-- Base application theme. -->
<style name="AppTheme" parent="Theme.AppCompat.Light.NoActionBar">
<!-- Customize your theme here. -->
<item name="android:textColor">#000000</item>
<item name="android:windowTranslucentStatus">true</item> <-- Add this
</style>
<style name="BootTheme" parent="AppTheme">
<!-- set the generated bootsplash.xml drawable as activity background -->
<item name="android:background">@drawable/bootsplash</item>
</style>
</resources> It fixes the jump. Now we will have a Translucent status bar during the splash instead of the gray bar which can be seen in the linked video to the issue. Extraneous
|
@parasharrajat thanks for your proposal, for clearly explaining why that solution works, and for the adding a linked video - Please submit a PR when you have a chance 👍 |
@a-eid Thank you for your efforts, but I've decided not to move forward with your proposal. Next time, I'd highly recommend providing a detailed explanation as to why you are suggesting certain changes, and your proposal will also gain even more strength if you test it & submit screenshots and / or a video (whichever is appropriate to the proposal). Thanks again :) |
The solution to this issue caused a regression. @parasharrajat will need to resubmit a new solution. |
Changing issue back to a daily to keep track of regression. |
Wow good catch @roryabraham and thanks for reverting quickly 👍 |
PR is merged. Payment due on 7 May assuming no regressions. |
I'm OOO 7-11 May so I'm going to remove my assignment and reassign this to someone on the contributor team to pay this out 7 May. |
Triggered auto assignment to @Beamanator ( |
Triggered auto assignment to @kadiealexander ( |
Pls ignore, I added the wrong label for reassignment. |
I'm on it, will pay on the 7th. |
Paid and closed job on upwork |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Expected Result:
Loading screen logo is stable.
Actual Result:
Loading screen logo slightly shifts up before fading away.
Action Performed:
Workaround:
No need for workaround. Visual issue.
Platform:
Where is this issue occurring?
Web
iOS
Android ✔️
Desktop App
Mobile Web
Version Number: 1.0.29-0
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
shifts.mp4
Expensify/Expensify Issue URL:
View all open jobs on Upwork
From @quinthar https://expensify.slack.com/archives/C01GTK53T8Q/p1619062191006900
The text was updated successfully, but these errors were encountered: