Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hold for payment 7 May] Loading screen logo slightly shifts up before fading away. #2542

Closed
isagoico opened this issue Apr 22, 2021 · 22 comments · Fixed by #2567 or #2594
Closed

[hold for payment 7 May] Loading screen logo slightly shifts up before fading away. #2542

isagoico opened this issue Apr 22, 2021 · 22 comments · Fixed by #2567 or #2594
Assignees
Labels
Engineering External Added to denote the issue can be worked on by a contributor Improvement Item broken or needs improvement. Weekly KSv2

Comments

@isagoico
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Expected Result:

Loading screen logo is stable.

Actual Result:

Loading screen logo slightly shifts up before fading away.

Action Performed:

  1. Kill the chat app if open
  2. Relaunch the app

Workaround:

No need for workaround. Visual issue.

Platform:

Where is this issue occurring?

Web
iOS
Android ✔️
Desktop App
Mobile Web

Version Number: 1.0.29-0

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

shifts.mp4

Expensify/Expensify Issue URL:

View all open jobs on Upwork


From @quinthar https://expensify.slack.com/archives/C01GTK53T8Q/p1619062191006900

ISSUE: the new loading screen starts with the icon in the middle, but then the shifts ever so slightly up right before disappearing. It reliably does this every time I "cold open" the app on Android

@isagoico isagoico added the AutoAssignerTriage Auto assign issues for triage to an available triage team member label Apr 22, 2021
@MelvinBot
Copy link

Triggered auto assignment to @Christinadobrzyn (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

@MelvinBot MelvinBot removed the AutoAssignerTriage Auto assign issues for triage to an available triage team member label Apr 22, 2021
@Christinadobrzyn
Copy link
Contributor

Christinadobrzyn commented Apr 23, 2021

Testing this on the E.cash mobile app on iOS.

I see the same 'shift' as well as line issues with the chats when following the Action Performed steps provided in the OP.

RPReplay_Final1619138891.MP4

The issue seems closely related to two current Upwork proposals but it's unclear if a fix on the other issues will resolve this issue - https://github.com/Expensify/Expensify/issues/160935 & https://github.com/Expensify/Expensify/issues/157743.

@Christinadobrzyn
Copy link
Contributor

I think this is ready for Eng to review and consider adding an External label.

@MelvinBot
Copy link

Triggered auto assignment to @NikkiWines (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@Christinadobrzyn Christinadobrzyn removed their assignment Apr 23, 2021
@NikkiWines NikkiWines added the Improvement Item broken or needs improvement. label Apr 23, 2021
@NikkiWines
Copy link
Contributor

This looks like a good issue for a contractor to work on, adding the external label so we can get this one UpWork.

@NikkiWines NikkiWines added the External Added to denote the issue can be worked on by a contributor label Apr 23, 2021
@MelvinBot
Copy link

Triggered auto assignment to @SofiedeVreese (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@MelvinBot
Copy link

Triggered auto assignment to @Beamanator (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@SofiedeVreese
Copy link
Contributor

Upwork Job Posting: https://www.upwork.com/jobs/~0159158ba1789b3203

@a-eid
Copy link

a-eid commented Apr 26, 2021

@SofiedeVreese I have not submitted a proposal on upwork, but I'll post the solution directly here

I believe that this line needs to be added to styles.xml <item name="android:windowTranslucentStatus">true</item>

I have not tested it, but I'm pretty sure it'll resolve the issue.

@parasharrajat
Copy link
Member

parasharrajat commented Apr 26, 2021

Proposal

  1. We have to set an attribute <item name="android:windowTranslucentStatus">true</item> in the AppTheme. Due to the reason that RNBootSplashActivity does not have a status bar and the MainActivity has, Ui jumps during the transition.
    https://github.com/Expensify/Expensify.cash/blob/f043f8a1aaea697ddb7e685262842d6eb5ba5648/android/app/src/main/res/values/styles.xml#L1-L12

Change above to

<resources>
    <!-- Base application theme. -->
    <style name="AppTheme" parent="Theme.AppCompat.Light.NoActionBar">
        <!-- Customize your theme here. -->
        <item name="android:textColor">#000000</item>
        <item name="android:windowTranslucentStatus">true</item> <-- Add this
    </style>

    <style name="BootTheme" parent="AppTheme">
        <!-- set the generated bootsplash.xml drawable as activity background -->
        <item name="android:background">@drawable/bootsplash</item>
    </style>

</resources>

It fixes the jump. Now we will have a Translucent status bar during the splash instead of the gray bar which can be seen in the linked video to the issue.

Extraneous

  1. If we want to change the navigation bar to be Translucent like the status bar we can add <item name="android:windowTranslucentNavigation">true</item> as well.

@Beamanator
Copy link
Contributor

@parasharrajat thanks for your proposal, for clearly explaining why that solution works, and for the adding a linked video - Please submit a PR when you have a chance 👍

@Beamanator
Copy link
Contributor

@a-eid Thank you for your efforts, but I've decided not to move forward with your proposal. Next time, I'd highly recommend providing a detailed explanation as to why you are suggesting certain changes, and your proposal will also gain even more strength if you test it & submit screenshots and / or a video (whichever is appropriate to the proposal). Thanks again :)

@roryabraham roryabraham changed the title [hold for payment 3 May] Loading screen logo slightly shifts up before fading away. Loading screen logo slightly shifts up before fading away. Apr 27, 2021
@roryabraham
Copy link
Contributor

roryabraham commented Apr 27, 2021

The solution to this issue caused a regression. @parasharrajat will need to resubmit a new solution.

@SofiedeVreese
Copy link
Contributor

Changing issue back to a daily to keep track of regression.

@SofiedeVreese SofiedeVreese added Daily KSv2 and removed Weekly KSv2 labels Apr 27, 2021
@Beamanator
Copy link
Contributor

Wow good catch @roryabraham and thanks for reverting quickly 👍

@SofiedeVreese SofiedeVreese added Weekly KSv2 and removed Daily KSv2 labels Apr 28, 2021
@SofiedeVreese SofiedeVreese changed the title Loading screen logo slightly shifts up before fading away. [hold for payment 7 May] Loading screen logo slightly shifts up before fading away. Apr 28, 2021
@SofiedeVreese
Copy link
Contributor

PR is merged. Payment due on 7 May assuming no regressions.

@SofiedeVreese SofiedeVreese reopened this Apr 28, 2021
@SofiedeVreese
Copy link
Contributor

SofiedeVreese commented May 3, 2021

I'm OOO 7-11 May so I'm going to remove my assignment and reassign this to someone on the contributor team to pay this out 7 May.

@SofiedeVreese SofiedeVreese removed their assignment May 3, 2021
@MelvinBot
Copy link

Triggered auto assignment to @Beamanator (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@SofiedeVreese SofiedeVreese added External Added to denote the issue can be worked on by a contributor and removed External Added to denote the issue can be worked on by a contributor labels May 3, 2021
@MelvinBot
Copy link

Triggered auto assignment to @kadiealexander (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@SofiedeVreese
Copy link
Contributor

Triggered auto assignment to @Beamanator (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

Pls ignore, I added the wrong label for reassignment.

@kadiealexander
Copy link
Contributor

I'm on it, will pay on the 7th.

@laurenreidexpensify
Copy link
Contributor

Paid and closed job on upwork

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering External Added to denote the issue can be worked on by a contributor Improvement Item broken or needs improvement. Weekly KSv2
Projects
None yet