Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't show the Download App Banner until Past Sign in #26182

Merged
merged 13 commits into from
Aug 29, 2023
Merged

Don't show the Download App Banner until Past Sign in #26182

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
5af5792
initial fix
grgia Aug 25, 2023
04d0195
Merge branch 'main' into georgia-downloadAppBannerFixes
grgia Aug 28, 2023
3b1362d
fix`
grgia Aug 28, 2023
ac3dd94
remove spaces
grgia Aug 28, 2023
9673fde
Merge branch 'main' into georgia-downloadAppBannerFixes
grgia Aug 29, 2023
84edf34
Show download app modal BEFORE welcome message
grgia Aug 29, 2023
c39de0e
remove debugging statements
grgia Aug 29, 2023
1a04732
ignore this for non mWeb cases
grgia Aug 29, 2023
b3be15a
pass down isAuthenticated
grgia Aug 29, 2023
2351c41
Fix lint
grgia Aug 29, 2023
460b2e6
add dependency to useEffect
grgia Aug 29, 2023
5df5de8
lint
grgia Aug 29, 2023
c0e1409
early return, rename to shouldShowDownloadAppBanner
grgia Aug 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/pages/home/sidebar/SidebarScreen/FloatingActionButtonAndPopover.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import lodashGet from 'lodash/get';
import {View} from 'react-native';
import styles from '../../../../styles/styles';
import * as Expensicons from '../../../../components/Icon/Expensicons';
import * as Browser from '../../../../libs/Browser';
import Navigation from '../../../../libs/Navigation/Navigation';
import ROUTES from '../../../../ROUTES';
import NAVIGATORS from '../../../../NAVIGATORS';
Expand Down Expand Up @@ -157,7 +158,7 @@ function FloatingActionButtonAndPopover(props) {
if (currentRoute && ![NAVIGATORS.CENTRAL_PANE_NAVIGATOR, SCREENS.HOME].includes(currentRoute.name)) {
return;
}
if (!props.showDownloadAppBanner) {
if (!props.showDownloadAppBanner || !Browser.isMobile()) {
grgia marked this conversation as resolved.
Show resolved Hide resolved
neil-marcellini marked this conversation as resolved.
Show resolved Hide resolved
Welcome.show({routes, showCreateMenu});
}
});
Expand Down
Loading