Fixed no result found after selecting a address from the drop-down menu #27035

shubham1206agra · 2023-09-08T15:39:02Z

Details

Fixed Issues

$ #25595
PROPOSAL: #25595 (comment)

Tests

Navigate to Settings > Wallet > Add a debit card.
Click "Billing address" and start typing any address.
Choose an address from the available options.
Click "Billing address" again once an address is selected.

Verify that no errors appear in the JS console
Verify that once we start typing, we get a loading indicator (or Cargando in Spanish) in step 2
Verify that after selecting Billing address again in step 4, we don't see any No result found.

QA Steps

Same as Tests

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-09-08.at.9.13.02.PM.mov

Mobile Web - Chrome

Screen.Recording.2023-09-08.at.9.20.01.PM.mov

Mobile Web - Safari

Screen.Recording.2023-09-08.at.9.23.43.PM.mov

Desktop

Screen.Recording.2023-09-08.at.9.28.52.PM.mov

iOS

Screen.Recording.2023-09-08.at.9.34.05.PM.mov

Android

Screen.Recording.2023-09-08.at.10.04.02.PM.mov

melvin-bot · 2023-09-08T15:39:05Z

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

melvin-bot · 2023-09-08T15:39:07Z

@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

shubham1206agra · 2023-09-09T08:26:41Z

@mananjadhav Can you review this today?

mananjadhav · 2023-09-11T02:19:24Z

@shubham1206agra Apologies I was away for the weekend. I did test, and the Test steps work fine, but this particular case doesn't.

When I start searching or type only one letter, it momentarily shows No results found, before loading the results.

no-results-found.mov

I tried figuring out an easy fix but I can't see how. Can you fix it? I am now wondering if @Pujan92's solution of fixing it in the lib would be needed. Will wait for your fix before testing again.

shubham1206agra · 2023-09-11T03:10:58Z

@shubham1206agra Apologies I was away for the weekend. I did test, and the Test steps work fine, but this particular case doesn't.

When I start searching or type only one letter, it momentarily shows No results found, before loading the results.
no-results-found.mov

I tried figuring out an easy fix but I can't see how. Can you fix it? I am now wondering if @Pujan92's solution of fixing it in the lib would be needed. Will wait for your fix before testing again.

@mananjadhav This issue is due to the synchronous nature of API calls in lib. I also checked that @Pujan92's solution did not work for the above issue. I think we should do nothing about this as this may introduce regression in other areas, and it's a minor issue.

shubham1206agra · 2023-09-13T07:49:50Z

@mananjadhav ?

mananjadhav · 2023-09-16T18:36:08Z

@AndrewGable Can you please check this case and confirm if this is fine?

AndrewGable · 2023-09-18T03:04:46Z

Does this happen on the existing build?

mananjadhav · 2023-09-18T03:07:41Z

Yes it does @AndrewGable

AndrewGable · 2023-09-18T04:22:11Z

It would be really nice to fix this, how complex would the solution be?

shubham1206agra · 2023-09-18T07:40:47Z

It would be really nice to fix this, how complex would the solution be?

It will require patching upstream, with not so sure solution. I think we should directly open upstream PR for this as patching locally might create some problems.

Which can be done after we merge this PR as a follow up

mananjadhav · 2023-09-20T07:10:17Z

@AndrewGable Our current approach won't work, and then we'll have to fix it upstream. I won't say it is complex, the idea is to expose the props while the API is being fetched.

AndrewGable · 2023-09-20T08:00:14Z

We have our own fork so fixing upstream seems like just as easy to fix it the "right" way as this PR. I am happy to help make sure it is deployed correctly, etc.

shubham1206agra · 2023-09-20T09:48:03Z

@mananjadhav Please decide in that case, and if upstream changes are needed, please create a fork so that I can work on that.

shubham1206agra · 2023-09-20T09:52:20Z

Btw we need to fix this issue in short
FaridSafi/react-native-google-places-autocomplete#751

mananjadhav · 2023-09-20T18:09:29Z

Yes @shubham1206agra but the fix will be pushed in this forked repo

shubham1206agra · 2023-09-21T11:56:53Z

I am gonna close this one and reopen another PR when upstream changes are made

shubham1206agra · 2023-09-22T12:14:27Z

I am gonna reopen this PR. Looks like you also need these changes too!

shubham1206agra · 2023-09-26T05:38:31Z

@mananjadhav You can start testing this PR

shawnborton · 2023-10-02T18:28:34Z

I feel like we can get rid of the text and only use the loading spinner, but we should vertically and horizontally center the spinner. cc @Expensify/design

shubham1206agra · 2023-10-02T18:36:26Z

I will wait on FaridSafi/react-native-google-places-autocomplete#913 to be merged
This will fix the spinner

mananjadhav · 2023-10-03T05:09:59Z

@shubham1206agra Did you get a chance to look at @shawnborton's comment? I think we want the wrapper to be equal to the width of the input (or the list items). No text and only spinner.

shubham1206agra · 2023-10-03T05:11:37Z

I thought @shawnborton is verifying this with Design team.
@shawnborton What should be the ideal UI?
Can you clarify?

shawnborton · 2023-10-03T10:34:13Z

I think we're all good to move forward with just vertically and horizontally centering the loading spinner, no need for a text label.

shubham1206agra · 2023-10-03T13:40:49Z

@mananjadhav Please complete the checklist now

mananjadhav · 2023-10-03T18:41:27Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web-address-search.mov

Mobile Web - Chrome

mweb-chrome-address-search.mov

Mobile Web - Safari

mweb-safari-address-search.mov

Desktop

desktop-address-search.mov

iOS

ios-address-search.mov

Android

android-address-search.mov

Thanks @shubham1206agra for the changes. This looks better. Thank you for taking this to the finish line.

mananjadhav · 2023-10-03T18:43:29Z

@shubham1206agra

Okay I noticed one thing intermittently, I got two console errors. Can you please check. I think we're only left with this.

shubham1206agra · 2023-10-04T02:06:29Z

@shubham1206agra

Okay I noticed one thing intermittently, I got two console errors. Can you please check. I think we're only left with this.

This is another bug with the library
Can we create a separate ticket for the same?
Cause this is not really related to this

mananjadhav · 2023-10-04T02:46:34Z

Yeah not directly related to the change here, but good to fix. I'll let @AndrewGable decide. All good from my side.

🎀 👀 🎀 C+ reviewed.

shubham1206agra · 2023-10-04T12:27:38Z

@AndrewGable Can you please review this?

melvin-bot · 2023-10-05T22:00:50Z

@AndrewGable looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

AndrewGable · 2023-10-05T22:02:05Z

Tests were still running I guess, not emergency.

OSBotify · 2023-10-05T22:08:28Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

shubham1206agra · 2023-10-06T04:09:26Z

@AndrewGable Can you create an issue for this?
#27035 (comment)

OSBotify · 2023-10-06T08:23:42Z

🚀 Deployed to staging by https://github.com/AndrewGable in version: 1.3.79-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

AndrewGable · 2023-10-06T15:51:42Z

I'd report these via #expensify-bugs Slack channel

OSBotify · 2023-10-09T22:32:16Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.79-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-10-09T22:41:09Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.79-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-10-09T23:17:03Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.79-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

fixed no result found on opening selected address

898da23

shubham1206agra requested a review from a team as a code owner September 8, 2023 15:39

melvin-bot bot removed the request for review from a team September 8, 2023 15:39

melvin-bot bot requested a review from mananjadhav September 8, 2023 15:39

mananjadhav mentioned this pull request Sep 14, 2023

[HOLD for payment 2023-10-16] [$1000] Dev: The "No result found" message showing after selecting a address from the drop-down menu #25595

Closed

6 tasks

shubham1206agra closed this Sep 21, 2023

shubham1206agra reopened this Sep 22, 2023

shubham1206agra and others added 3 commits September 22, 2023 17:56

Merge branch 'Expensify:main' into fix-25595

2c031ea

Merge branch 'Expensify:main' into fix-25595

d1febb7

updated logic

1006894

fix translation

a6e7171

mananjadhav mentioned this pull request Oct 3, 2023

Fix abort request FaridSafi/react-native-google-places-autocomplete#913

Merged

fix UI

dd00fc4

remove extra language

7c3ed3a

AndrewGable approved these changes Oct 5, 2023

View reviewed changes

AndrewGable merged commit 23d5953 into Expensify:main Oct 5, 2023
14 checks passed

melvin-bot bot added the Emergency label Oct 5, 2023

AndrewGable removed the Emergency label Oct 5, 2023

OSBotify mentioned this pull request Oct 6, 2023

Deploy Checklist: New Expensify 2023-10-06 #28983

Closed

tienifr mentioned this pull request Oct 7, 2023

[HOLD for payment 2023-11-09] [$500] BA - Part of the screen shakes when entering an address offline #29030

Closed

6 tasks

shubham1206agra deleted the fix-25595 branch February 6, 2024 03:02

Fixed no result found after selecting a address from the drop-down menu #27035

Fixed no result found after selecting a address from the drop-down menu #27035

Conversation

shubham1206agra commented Sep 8, 2023 • edited Loading

Details

Fixed Issues

Tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Sep 8, 2023

melvin-bot bot commented Sep 8, 2023

shubham1206agra commented Sep 9, 2023

mananjadhav commented Sep 11, 2023

shubham1206agra commented Sep 11, 2023

shubham1206agra commented Sep 13, 2023

mananjadhav commented Sep 16, 2023

AndrewGable commented Sep 18, 2023

mananjadhav commented Sep 18, 2023

AndrewGable commented Sep 18, 2023

shubham1206agra commented Sep 18, 2023 • edited Loading

mananjadhav commented Sep 20, 2023

AndrewGable commented Sep 20, 2023

shubham1206agra commented Sep 20, 2023

shubham1206agra commented Sep 20, 2023

mananjadhav commented Sep 20, 2023 • edited Loading

shubham1206agra commented Sep 21, 2023

shubham1206agra commented Sep 22, 2023

shubham1206agra commented Sep 26, 2023

shawnborton commented Oct 2, 2023

shubham1206agra commented Oct 2, 2023 • edited Loading

mananjadhav commented Oct 3, 2023

shubham1206agra commented Oct 3, 2023

shawnborton commented Oct 3, 2023

shubham1206agra commented Oct 3, 2023

mananjadhav commented Oct 3, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

mananjadhav commented Oct 3, 2023 • edited Loading

shubham1206agra commented Oct 4, 2023

mananjadhav commented Oct 4, 2023

shubham1206agra commented Oct 4, 2023

melvin-bot bot commented Oct 5, 2023

AndrewGable commented Oct 5, 2023

OSBotify commented Oct 5, 2023

shubham1206agra commented Oct 6, 2023

OSBotify commented Oct 6, 2023

AndrewGable commented Oct 6, 2023

OSBotify commented Oct 9, 2023

OSBotify commented Oct 9, 2023

OSBotify commented Oct 9, 2023

shubham1206agra commented Sep 8, 2023 •

edited

Loading

shubham1206agra commented Sep 18, 2023 •

edited

Loading

mananjadhav commented Sep 20, 2023 •

edited

Loading

shubham1206agra commented Oct 2, 2023 •

edited

Loading

mananjadhav commented Oct 3, 2023 •

edited

Loading

mananjadhav commented Oct 3, 2023 •

edited

Loading