-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix inconsistent margins for reacted emojis to code-block comments #28387
Fix inconsistent margins for reacted emojis to code-block comments #28387
Conversation
…/18681-inconsistent-margins
…/18681-inconsistent-margins
…/18681-inconsistent-margins
…/18681-inconsistent-margins
…/18681-inconsistent-margins
@abdulrahuman5196 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
@rezkiy37 If we have multiple code blocks in the same comment , the change is causing the distance between code block and normal text With new change Without the change |
…/18681-inconsistent-margins
@abdulrahuman5196, yeah, good catch. So, I have an idea:
We need to decide when to render a bottom margin, when not. I think the best way how to do it is:
I actually very like this idea, because we fix the root cause of the problem and do not introduces any new UI/UX changes/behaviour. Also, we don't pass any additional props. Moreover, we don't create a dependency between different messages. Please test this commit - 677c357 - to verify that it looks good. |
@rezkiy37 Wasn't this your first proposal - #18681 (comment)? But you dropped it due to some issues. Let me know if the new approach is different? |
No, it is different to that main proposal. It is a improved version of our alternative variant. |
@rezkiy37 #18681 (comment) Is this different? If the new proposal is really different and working fine, I am fine with it. |
@abdulrahuman5196, I got you now. So, it is not different what we had there. I see that you were okay with this idea previously. Are you good now? |
@rezkiy37 I was ok with it previously itself. But I remember you had mentioned it had some issues. Not sure, have to check back on previous conversations. |
I was so long ago, let me also check 😅 |
Interesting, I haven't found a reason why we didn't try this solution yet. I see we were discussing it, but implemented the other solutions. |
@rezkiy37 I think then its your call. If the proposal and change is working, I am fine with the proposal and can do platform testing |
…/18681-inconsistent-margins
@abdulrahuman5196, I've checked on different platforms with different messages, looks good to me. Let's do platform testing. |
@rezkiy37 There have been lint failures. |
…/18681-inconsistent-margins
@abdulrahuman5196, fixed 👍 |
Thank you will review today |
Taking a look now. |
Reviewer Checklist
Screenshots/VideosWebScreen.Recording.2023-10-05.at.8.59.35.PM.mp4Mobile Web - ChromeScreen.Recording.2023-10-05.at.9.03.03.PM.mp4Mobile Web - SafariScreen.Recording.2023-10-05.at.9.01.13.PM.mp4DesktopScreen.Recording.2023-10-05.at.9.07.47.PM.mp4iOSScreen.Recording.2023-10-05.at.9.04.07.PM.mp4AndroidScreen.Recording.2023-10-05.at.9.05.49.PM.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes looks good and works well. Reviewers checklist is also complete.
All yours. @Beamanator
🎀 👀 🎀
C+ Reviewed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Nice work both of you!!
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/Beamanator in version: 1.3.80-0 🚀
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.80-3 🚀
|
🚀 Deployed to staging by https://github.com/Beamanator in version: 1.3.81-0 🚀
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀
|
2 similar comments
🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀
|
🚀 Deployed to production by https://github.com/francoisl in version: 1.3.84-10 🚀
|
🚀 Deployed to production by https://github.com/francoisl in version: 1.3.84-10 🚀
|
Details
This is an alternative fix to align spacing between messages and their reactions. The first attempt was unsuccessful, because of the complexity and many overheads.
After investigation, the problems occurs for code-blocks and their reactions, because it has an extra margin bottom.
Good to know: #22010 (comment), #22010 (comment).
Fixed Issues
$ #18681
PROPOSAL: #18681 (comment) (alternative solution)
Tests
Offline tests
Same as "Tests".
QA Steps
Same as "Tests".
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Web
Mobile Web - Chrome
Mobile Web - Safari
Desktop
iOS
Android