Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inconsistent margins for reacted emojis to code-block comments #28387

Merged
merged 11 commits into from
Oct 6, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,12 @@ const propTypes = {
/** Press out handler for the code block */
onPressOut: PropTypes.func,

/** The position of this React element relative to the parent React element, starting at 0 */
renderIndex: PropTypes.number.isRequired,

/** The total number of elements children of this React element parent */
renderLength: PropTypes.number.isRequired,

...htmlRendererPropTypes,
};

Expand All @@ -29,12 +35,13 @@ const defaultProps = {
const BasePreRenderer = forwardRef((props, ref) => {
const TDefaultRenderer = props.TDefaultRenderer;
const defaultRendererProps = _.omit(props, ['TDefaultRenderer', 'onPressIn', 'onPressOut', 'onLongPress']);
const isLast = props.renderIndex === props.renderLength - 1;

return (
<ScrollView
ref={ref}
horizontal
style={[styles.mv2, styles.overscrollBehaviorXNone]}
style={[isLast ? styles.mt2 : styles.mv2, styles.overscrollBehaviorXNone]}
bounces={false}
keyboardShouldPersistTaps="always"
>
Expand Down
Loading