-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed offline jumping behaviour #29045
fixed offline jumping behaviour #29045
Conversation
Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers! |
This will work for now. |
Please do not merge before |
@shubham1206agra sorry i am confused should we go ahead with the fix in this pr? |
I am trying to get upstream PR merged |
@shubham1206agra Alright I have remoevd the deploy blocker label so we dont have to rush so much as with upstream that might take longer |
PR is ready for review |
Reviewer Checklist
Screenshots/VideosWeb29045.Web.mp4Mobile Web - Chrome29045.mWeb-Chrome.mp4Mobile Web - Safari29045.mWeb.Safari.mp4Desktop29045.Desktop.mp4iOS29045.iOS.mp4Android29045.Android.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the late review. I just got out from the hospital after surgery on my right hand because of the motorcycle accident 🙏
The test looks good on all platforms. @shubham1206agra, Could you please complete the test recordings so I can approve the PR? Thank you!
Friendly bump @shubham1206agra to complete the recordings. |
I will complete this today |
Friendly bump @shubham1206agra for the recordings. |
My Android emulator is crashing on start. If you are fine without Android recordings, then I will update it in 15 mins |
If you are fine without android, all the remaining recordings has been uploaded. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we are okay to use the recordings for mWeb/Chrome and Android from mine. I just check the latest commit on all platforms and it still working well.
All yours @marcochavezf
Friendly bump @marcochavezf for final review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving again to trigger the internal engineer.
LGTM, thanks guys! |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/marcochavezf in version: 1.3.94-0 🚀
|
1 similar comment
🚀 Deployed to staging by https://github.com/marcochavezf in version: 1.3.94-0 🚀
|
🚀 Deployed to production by https://github.com/Beamanator in version: 1.3.94-2 🚀
|
🚀 Deployed to staging by https://github.com/marcochavezf in version: 1.3.95-0 🚀
|
🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.95-9 🚀
|
Details
Fixes offline jumping behaviour due to quick uncaught error in non-web platforms
Fixed Issues
$ #29030
Tests
Offline tests
Same as Tests
QA Steps
Same as Tests
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Web
Screen.Recording.2023-10-18.at.8.40.12.AM.mov
Mobile Web - Chrome
Mobile Web - Safari
Screen.Recording.2023-10-18.at.8.46.33.AM.mov
Desktop
Screen.Recording.2023-10-18.at.8.51.20.AM.mov
iOS
Screen.Recording.2023-10-18.at.9.10.38.AM.mov
Android