[NoQA] Bump onyx - Fix out of order updates #29169

ospfranco · 2023-10-10T11:01:22Z

Details

Bumps onyx to take advantage of the following PRs:

Allow infinite dependent keys when using withOnyx

Fixed Issues

$ #28737
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2023-10-10T11:01:27Z

@jjcoffee Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mountiny · 2023-10-10T11:06:26Z

@pradeepmdk is there any specific bug in the App which we could use to QA this change?

pradeepmdk · 2023-10-10T11:15:35Z

@mountiny
Expensify/react-native-onyx#384 - no QA
Expensify/react-native-onyx#385 - here one #29165

mountiny · 2023-10-10T11:27:12Z

Thanks! That would require other changes in a Pr which I think can be a separate PR. I guess there is no specific QA right now

jjcoffee · 2023-10-10T11:38:00Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

chrome-desktop-2023-10-19_12.34.09.mp4

Mobile Web - Chrome

android-chrome.mp4

Mobile Web - Safari

ios-safari-2023-10-19_16.22.31.mp4

Desktop

mac-desktop-2023-10-19_16.14.49.mp4

iOS

ios-safari-2023-10-19_16.22.31.mp4

Android

android-native.mp4

jjcoffee · 2023-10-10T12:20:46Z

I'm getting replay effects when adding/removing emojis (fairly) quickly:

chrome-desktop-issue-2023-10-10_14.19.53.mp4

Same when going offline and adding a couple of money requests:

chrome-desktop-replay-offline-2023-10-10_14.42.53.mp4

@ospfranco Any idea if these could be related to your changes?

ospfranco · 2023-10-10T12:49:45Z

Hard to say. My changes might had increased the time it takes to process onyx updates, but I've never seen that replay effect. That being said there were other PRs that where merged, some which reverted other stuff. Here is the full list of changes:

Expensify/react-native-onyx#385
Expensify/react-native-onyx#319
Expensify/react-native-onyx#384
Expensify/react-native-onyx#388
Expensify/react-native-onyx#380

jjcoffee · 2023-10-10T12:52:43Z

@ospfranco Are you able to test with just your changes?

mountiny · 2023-10-10T12:52:59Z

@jjcoffee is this not repro on main?

jjcoffee · 2023-10-10T12:55:43Z

@mountiny No only on this PR.

ospfranco · 2023-10-10T13:10:45Z

I will try with only my changes later.

jjcoffee · 2023-10-10T14:11:10Z

Another issue with undefined showing in LHN when splitting with users with whom you have no previous chat history (not reproducible on main):

chrome-desktop-undefined-splits-2023-10-10_16.09.11.mp4

jjcoffee · 2023-10-10T14:28:44Z

Also tested both issues against #28894 (i.e. Onyx v1.0.100) and can't repro.

tgolen · 2023-10-10T15:05:55Z

@jjcoffee thanks for spotting that. I ran a git bisect on react-native-onyx and found this commit most likely caused the issue. We are discussing on Slack about what to do.

tgolen · 2023-10-17T17:01:50Z

What are the next steps with this? This is holding up some other issues like #28824

package.json

# Conflicts: # package-lock.json # package.json

OSBotify · 2023-10-19T10:29:31Z

🧪🧪 Use the links below to test this build in android and iOS. Happy testing! 🧪🧪

android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/29169/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/29169/index.html

desktop 💻	web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/29169/NewExpensify.dmg	https://29169.pr-testing.expensify.com

jjcoffee · 2023-10-19T10:50:04Z

The good news is I can't replicate any of the previous issues, the bad news is I found a new one! Not sure if it's a blocker but starting from a fresh session (sign out and back in) and requesting money from a workspace I get super high CPU usage and an endless loop of loading the avatars.

The only way to stop it seems to be to refresh the page (or interestingly to open FAB and select any option), then if you request from the same workspace it doesn't happen again, only for other workspaces. I couldn't replicate on staging.

chrome-desktop-cpu-mem-issue-2023-10-19_12.42.28.mp4

jjcoffee · 2023-10-19T15:13:09Z

Completed testing, no other issues found other than the above. Not sure if that's a blocker as the app does continue functioning, but it's definitely not ideal.

jjcoffee · 2023-10-25T08:52:11Z

Just adding repro steps for the above blocker:

Make sure you start from a fresh session (sign out and back in)
Open FAB -> Request Money
Make a manual request from any user or workspace
Observe the Network tab of Chrome DevTools as well as CPU usage in Task manager

You should see an endless loop loading profile pictures for the report as well as constant high CPU usage.

ospfranco · 2023-10-26T07:13:54Z

Bumped Onyx again. Here are a couple new PRs merged since the last bump:

Expensify/react-native-onyx#402
Expensify/react-native-onyx#401

ospfranco · 2023-10-26T07:17:48Z

I'm getting some weird behavior, some of the menu items are not loading for me or only appear after refreshing the page. Here is what I get when I click on the Request Money option on the FAB menu.

It also happened to me when I clicked on my user profile pic and tried to log out of the app.

tgolen · 2023-10-27T19:11:14Z

I was able to identify two problems (also discussed in this slack thread).

Modals are opening up blank - This was introduced in this commit from @janicduplessis and he is looking into the issue further to fix that particular problem.
Infinite avatars loading - This was introduced in this commit from me and I have a fix ready for this.

jjcoffee · 2023-10-30T15:31:08Z

Just noting here that it might be best to bump to 1.0.107 first as there's an issue in later versions that we haven't found the root of yet.

tgolen · 2023-11-02T22:16:22Z

I believe I have finally fixed issue 2 mentioned above (infinite re-rendering) with Expensify/react-native-onyx#412. You'll need to update to version 1.0.111 to have that fix.

jjcoffee · 2023-11-03T09:46:07Z

Looking good so far! @ospfranco Can you merge main so we have the latest and greatest?

jjcoffee

Tests well!

mountiny

Thanks @jjcoffee fore the review and testin

OSBotify · 2023-11-03T12:11:57Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-11-06T22:32:46Z

🚀 Deployed to staging by https://github.com/Julesssss in version: 1.3.96-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-11-09T22:50:19Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.96-15 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-11-10T15:47:03Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.97-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Bump onyx

b2a9994

ospfranco requested a review from a team as a code owner October 10, 2023 11:01

melvin-bot bot requested review from jjcoffee and removed request for a team October 10, 2023 11:01

mountiny assigned ospfranco Oct 10, 2023

tgolen mentioned this pull request Oct 10, 2023

Fix concurrent writes in the update operation Expensify/react-native-onyx#384

Merged

This was referenced Oct 10, 2023

Revert "Fix concurrent writes in the update operation" Expensify/react-native-onyx#397

Merged

Remove duplicate withOnyx calls #28866

Merged

tgolen mentioned this pull request Oct 17, 2023

[$500] [HOLD for payment 2023-11-21] Remove multiple withOnyx nestings #28824

Closed

1 task

mountiny reviewed Oct 19, 2023

View reviewed changes

package.json Outdated Show resolved Hide resolved

Merge branch 'main' into osp/bump-onyx

d7ec978

# Conflicts: # package-lock.json # package.json

mountiny added the Ready To Build label Oct 19, 2023

ospfranco added 2 commits October 26, 2023 09:07

Merge branch 'main' into osp/bump-onyx

3e507ad

Bump onyx

667078f

Merge branch 'main' into osp/bump-onyx

0251efb

This was referenced Oct 27, 2023

Fix Expensify/react-native-onyx#406

Closed

Fix an incorrect method of looking up previous keys Expensify/react-native-onyx#407

Closed

janicduplessis mentioned this pull request Oct 28, 2023

Fix IDBKeyVal get returning undefined instead of null Expensify/react-native-onyx#408

Merged

42 tasks

Bump onyx

677729d

jjcoffee approved these changes Nov 3, 2023

View reviewed changes

melvin-bot bot requested a review from Julesssss November 3, 2023 10:37

mountiny changed the title ~~Bump onyx - Fix out of order updates~~ [NoQA] Bump onyx - Fix out of order updates Nov 3, 2023

mountiny approved these changes Nov 3, 2023

View reviewed changes

Julesssss approved these changes Nov 3, 2023

View reviewed changes

Julesssss merged commit cc6c08e into Expensify:main Nov 3, 2023
19 checks passed

ospfranco deleted the osp/bump-onyx branch November 3, 2023 13:19

OSBotify mentioned this pull request Nov 6, 2023

Deploy Checklist: New Expensify 2023-11-06 #30929

Closed

s-alves10 mentioned this pull request Nov 7, 2023

Chat - Emoji picker and send buttons appear on the left of composer briefly when opening chat #30950

Closed

6 tasks

bernhardoj mentioned this pull request Nov 7, 2023

[HOLD for payment 2023-11-17] Login - Chat loads infinitely after logging in unless user opens another chat #30934

Closed

6 tasks

OSBotify mentioned this pull request Nov 8, 2023

Deploy Checklist: New Expensify 2023-11-08 #31077

Closed

jjcoffee mentioned this pull request Nov 20, 2023

[$1000] Web - Onyx: out-of-order updates #28737

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[NoQA] Bump onyx - Fix out of order updates #29169

[NoQA] Bump onyx - Fix out of order updates #29169

ospfranco commented Oct 10, 2023 •

edited by mountiny

Loading

melvin-bot bot commented Oct 10, 2023

mountiny commented Oct 10, 2023

pradeepmdk commented Oct 10, 2023

mountiny commented Oct 10, 2023

jjcoffee commented Oct 10, 2023 •

edited

Loading

jjcoffee commented Oct 10, 2023 •

edited

Loading

ospfranco commented Oct 10, 2023

jjcoffee commented Oct 10, 2023

mountiny commented Oct 10, 2023

jjcoffee commented Oct 10, 2023

ospfranco commented Oct 10, 2023

jjcoffee commented Oct 10, 2023

jjcoffee commented Oct 10, 2023

tgolen commented Oct 10, 2023

tgolen commented Oct 17, 2023

OSBotify commented Oct 19, 2023

jjcoffee commented Oct 19, 2023 •

edited

Loading

jjcoffee commented Oct 19, 2023

jjcoffee commented Oct 25, 2023

ospfranco commented Oct 26, 2023

ospfranco commented Oct 26, 2023 •

edited

Loading

tgolen commented Oct 27, 2023

jjcoffee commented Oct 30, 2023

tgolen commented Nov 2, 2023

jjcoffee commented Nov 3, 2023

jjcoffee left a comment

mountiny left a comment

OSBotify commented Nov 3, 2023

OSBotify commented Nov 6, 2023

OSBotify commented Nov 9, 2023

OSBotify commented Nov 10, 2023

[NoQA] Bump onyx - Fix out of order updates #29169

[NoQA] Bump onyx - Fix out of order updates #29169

Conversation

ospfranco commented Oct 10, 2023 • edited by mountiny Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Oct 10, 2023

mountiny commented Oct 10, 2023

pradeepmdk commented Oct 10, 2023

mountiny commented Oct 10, 2023

jjcoffee commented Oct 10, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

jjcoffee commented Oct 10, 2023 • edited Loading

ospfranco commented Oct 10, 2023

jjcoffee commented Oct 10, 2023

mountiny commented Oct 10, 2023

jjcoffee commented Oct 10, 2023

ospfranco commented Oct 10, 2023

jjcoffee commented Oct 10, 2023

jjcoffee commented Oct 10, 2023

tgolen commented Oct 10, 2023

tgolen commented Oct 17, 2023

OSBotify commented Oct 19, 2023

jjcoffee commented Oct 19, 2023 • edited Loading

jjcoffee commented Oct 19, 2023

jjcoffee commented Oct 25, 2023

ospfranco commented Oct 26, 2023

ospfranco commented Oct 26, 2023 • edited Loading

tgolen commented Oct 27, 2023

jjcoffee commented Oct 30, 2023

tgolen commented Nov 2, 2023

jjcoffee commented Nov 3, 2023

jjcoffee left a comment

Choose a reason for hiding this comment

mountiny left a comment

Choose a reason for hiding this comment

OSBotify commented Nov 3, 2023

OSBotify commented Nov 6, 2023

OSBotify commented Nov 9, 2023

OSBotify commented Nov 10, 2023

ospfranco commented Oct 10, 2023 •

edited by mountiny

Loading

jjcoffee commented Oct 10, 2023 •

edited

Loading

jjcoffee commented Oct 10, 2023 •

edited

Loading

jjcoffee commented Oct 19, 2023 •

edited

Loading

ospfranco commented Oct 26, 2023 •

edited

Loading