Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix concurrent writes in the update operation" #397

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

tgolen
Copy link
Collaborator

@tgolen tgolen commented Oct 10, 2023

This is a straight revert of #384 because it was identified as causing a regression of the "replace effect"

Details

Related Issues

Expensify/App#29169 (comment)

Automated Tests

None

Manual Tests

Will be tested as part of Expensify/App#29169

@tgolen tgolen self-assigned this Oct 10, 2023
@tgolen tgolen requested a review from a team as a code owner October 10, 2023 16:01
@melvin-bot melvin-bot bot requested review from arosiclair and removed request for a team October 10, 2023 16:02
Copy link
Contributor

@mountiny mountiny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straight revert

Copy link
Contributor

@mountiny mountiny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong radio button

@mountiny mountiny merged commit 24a51ba into main Oct 10, 2023
3 checks passed
@tgolen tgolen deleted the revert-384-osp/fix-concurrent-writes branch October 10, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants