fix: set null to unread marker when there are no new messages #30485

s-alves10 · 2023-10-27T09:12:18Z

Details

Fixed Issues

$ #30359
PROPOSAL: #30359 (comment)

Tests

Open ND and log in with any account
Navigate to any chat. Ensure that have enough messages on the chat so you're able to scroll
Send message A
Mark message A as unread
Scroll up and verify that the "New messages" notification appears
Delete the last message
Scroll up and verify that the "New messages" notification doesn't appear

Verify that no errors appear in the JS console

Offline tests

Open ND and log in with any account
Navigate to any chat. Ensure that have enough messages on the chat so you're able to scroll
Send message A
Mark message A as unread
Scroll up and verify that the "New messages" notification appears
Delete the last message
Scroll up and verify that the "New messages" notification doesn't appear

QA Steps

Open ND and log in with any account
Navigate to any chat. Ensure that have enough messages on the chat so you're able to scroll
Send message A
Mark message A as unread
Scroll up and verify that the "New messages" notification appears
Delete the last message
Scroll up and verify that the "New messages" notification doesn't appear

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

30359_android_native.mp4

Android: mWeb Chrome

30359_android_chrome.mp4

iOS: Native

30359_ios_native.mp4

iOS: mWeb Safari

30359_ios_safari.mp4

MacOS: Chrome / Safari

30359_mac_chrome.mp4

MacOS: Desktop

30359_mac_desktop.mp4

melvin-bot · 2023-10-27T09:22:32Z

@ArekChr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ArekChr · 2023-10-27T10:30:43Z

@s-alves10 There is a small glitch. When removing the last unread message, the divider with a new mark is between the composer and the last message. It appears for a second after syncing with the backend. Could you take a look into that and fix it?

Nagranie.z.ekranu.2023-10-27.o.12.26.29.mov

s-alves10 · 2023-10-27T12:42:28Z

@ArekChr

This seems to be another issue, not related to the current issue

ArekChr · 2023-10-30T09:01:22Z

@s-alves10, this appears to be connected to the issue we're currently addressing. Could you take a look and implement a solution? It should be a straightforward fix. Thanks!

s-alves10 · 2023-10-30T10:05:38Z

There is a small glitch. When removing the last unread message, the divider with a new mark is between the composer and the last message. It appears for a second after syncing with the backend.

@ArekChr

The root cause of this issue is in the below code

App/src/libs/ReportActionsUtils.ts

Lines 320 to 322 in 345a3a1

    
           const isDeleted = isDeletedAction(reportAction); 
        
           const isPending = !!reportAction.pendingAction; 
        
           return !isDeleted || isPending || isDeletedParentAction(reportAction) || isReversedTransaction(reportAction);

As you can see, we treat all pending actions as visible action. So the deleted message would be displayed until the API call returns. We need not to show the deleted actions, I think. The following updates would fix the issue

    const isPending = !!reportAction.pendingAction && !(!isNetworkOffline && reportAction.pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE);

Of course, we can add a condition when calculating currentUnreadMarker, but I think this is a workaround

As you can see above, the new issue looks like beyond the scope of this issue, also that is reproducible in staging/production as well. Do you still want to fix the glitching issue in this PR?

ArekChr · 2023-10-30T10:46:33Z

@s-alves10, Thanks for looking into this. Let's handle this issue in a separate PR to ensure we can focus solely on resolving it

ArekChr · 2023-10-30T10:46:55Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

mweb.chrome.mov

iOS: Native

ios.mov

iOS: mWeb Safari

mweb.safari.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

ArekChr

All works, thanks for PR!

OSBotify · 2023-10-30T11:38:58Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-10-31T22:01:04Z

🚀 Deployed to staging by https://github.com/madmax330 in version: 1.3.94-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-11-01T08:53:03Z

🚀 Deployed to staging by https://github.com/madmax330 in version: 1.3.94-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-11-02T10:16:24Z

🚀 Deployed to production by https://github.com/Beamanator in version: 1.3.94-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-11-02T10:41:14Z

🚀 Deployed to staging by https://github.com/madmax330 in version: 1.3.95-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-11-06T22:11:17Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.95-9 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fix: set null to unread marker when there are no new messages

50f22be

s-alves10 marked this pull request as ready for review October 27, 2023 09:22

s-alves10 requested a review from a team as a code owner October 27, 2023 09:22

melvin-bot bot requested review from ArekChr and removed request for a team October 27, 2023 09:22

s-alves10 mentioned this pull request Oct 27, 2023

[HOLD for payment 2023-11-09] [$500] A "New Messages" notification is shown when there is no new message #30359

Closed

6 tasks

ArekChr approved these changes Oct 30, 2023

View reviewed changes

melvin-bot bot requested a review from madmax330 October 30, 2023 11:10

madmax330 approved these changes Oct 30, 2023

View reviewed changes

madmax330 merged commit 9281342 into Expensify:main Oct 30, 2023
15 checks passed

OSBotify mentioned this pull request Oct 31, 2023

Deploy Checklist: New Expensify 2023-10-31 #30662

Closed

97 tasks

izarutskaya mentioned this pull request Nov 1, 2023

[HOLD for payment 2023-11-13] [HOLD for payment 2023-11-09] [$500] Chat - Tapping "Mark as unread option" not showing green line above message #30684

Closed

6 tasks

OSBotify mentioned this pull request Nov 2, 2023

Deploy Checklist: New Expensify 2023-11-02 #30752

Closed

roksanaz mentioned this pull request Nov 2, 2023

[HOLD for payment 2023-11-13] [HOLD for payment 2023-11-09] Unread message - When delete unread message green line blinks and goes to the next message #30696

Closed

6 tasks

This was referenced Nov 21, 2023

[Paid] [$500] Chat - Unread message green line marker remains after opening the new message #31623

Closed

[HOLD for payment 2024-01-17] [$500] Threads - When deleting the last unread message, the "New" marker appears for a second #31637

Closed

s-alves10 mentioned this pull request Dec 5, 2023

fix: hide pending deleted actions #32474

Merged

47 tasks

s-alves10 deleted the fix/issue-30359 branch December 21, 2023 07:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: set null to unread marker when there are no new messages #30485

fix: set null to unread marker when there are no new messages #30485

s-alves10 commented Oct 27, 2023

melvin-bot bot commented Oct 27, 2023

ArekChr commented Oct 27, 2023

s-alves10 commented Oct 27, 2023

ArekChr commented Oct 30, 2023

s-alves10 commented Oct 30, 2023

ArekChr commented Oct 30, 2023

ArekChr commented Oct 30, 2023 •

edited

Loading

ArekChr left a comment

OSBotify commented Oct 30, 2023

OSBotify commented Oct 31, 2023

OSBotify commented Nov 1, 2023

OSBotify commented Nov 2, 2023

OSBotify commented Nov 2, 2023

OSBotify commented Nov 6, 2023

fix: set null to unread marker when there are no new messages #30485

fix: set null to unread marker when there are no new messages #30485

Conversation

s-alves10 commented Oct 27, 2023

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Oct 27, 2023

ArekChr commented Oct 27, 2023

s-alves10 commented Oct 27, 2023

ArekChr commented Oct 30, 2023

s-alves10 commented Oct 30, 2023

ArekChr commented Oct 30, 2023

ArekChr commented Oct 30, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

ArekChr left a comment

Choose a reason for hiding this comment

OSBotify commented Oct 30, 2023

OSBotify commented Oct 31, 2023

OSBotify commented Nov 1, 2023

OSBotify commented Nov 2, 2023

OSBotify commented Nov 2, 2023

OSBotify commented Nov 6, 2023

ArekChr commented Oct 30, 2023 •

edited

Loading