[HOLD for payment 2023-11-13] [HOLD for payment 2023-11-09] [$500] Chat - Tapping "Mark as unread option" not showing green line above message

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when executing PR: #30485

Version Number: 1.3.94-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Tap on a report
3. Send a message
   4.Long press the message sent and select "mark as unread"

Expected Result:

Tapping "Mark as unread option" must show green line above message and "new message" tag on top of chat.

Actual Result:

Tapping "Mark as unread option" is not showing green line above message and "new message" tag on top of chat.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Bug6258813_1698802778618.an20485.mp4

Android: mWeb Chrome

Bug6258813_1698802778617.30485mweb.mp4

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Bug6258813_1698802974111.web30485.mp4

MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01ae8b38a2373a909a
• Upwork Job ID: 1719689014318288896
• Last Price Increase: 2023-11-01

[melvin-bot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01ae8b38a2373a909a

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @Li357 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[erquhart]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Marking a new message unread does not cause the message to be marked unread until page reload.

What is the root cause of that problem?

Introduced in this PR: #29860

Because the message creation time is always after userActiveSince.current, the message is not considered to be within the visible threshold, event though it actually is.

What changes do you think we should make in order to solve the problem?

This was a regression from an otherwise intentional bugfix, logic should be added to show the new marker if the current user marks the message as new without regressing the overall fix from the PR linked above.

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[situchan]

@roksanaz can you please check this?

[situchan]

@MonilBhavsar I think we should revert #29860 to unblock deploy.
And find better solution which also handles self unread cases.

[erquhart]

@situchan just a contributor's two cents - this bug alone, assuming there aren't others, is far preferable to the behavior that #29860 fixes. I personally wouldn't roll it back for this.

[MonilBhavsar]

@situchan I reverted, if you could please review #30712. thanks!

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.94-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Revert "27456 Chat - The green line is displayed chaotically at the recipient" #30712

If no regressions arise, payment will be issued on 2023-11-09. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @jjcoffee requires payment

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@jjcoffee] The PR that introduced the bug has been identified. Link to the PR:
• [@jjcoffee] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@jjcoffee] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@jjcoffee] Determine if we should create a regression test for this bug.
• [@jjcoffee] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@stephanieelliott] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[jjcoffee]

No payments due here!

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.95-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Revert "27456 Chat - The green line is displayed chaotically at the recipient" #30712

If no regressions arise, payment will be issued on 2023-11-13. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@Li357] The PR that introduced the bug has been identified. Link to the PR: 27456 Chat - The green line is displayed chaotically at the recipient #29860
• [@Li357] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: 27456 Chat - The green line is displayed chaotically at the recipient #29860 (comment)
• [@Li357] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• [@Li357] Determine if we should create a regression test for this bug. N/A
• [@Li357] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@stephanieelliott] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[stephanieelliott]

Hey @Li357 can you complete the BZ checklist please?

[Li357]

Working on it now!

[Li357]

Checked off things because it looks like @MonilBhavsar has handled getting another PR out

[stephanieelliott]

Summarizing payment on this issue:

• Issue reporter: N/A, reported by Applause
• Contributor: N/A, internal
• Contributor+: @jjcoffee, $500 - extended offer on Upwork, please accept when you get a chance!

Upwork job is here, no bonus on final payout

[jjcoffee]

@stephanieelliott No payment is due here to me. I think this was a regression too so @situchan is also not due payment as far as I can tell (feel free to correct me if I'm wrong!).

[situchan]

No action needed here. Let's close this!

[stephanieelliott]

Cool, thanks guys!