27456 Chat - The green line is displayed chaotically at the recipient #29860

roksanaz · 2023-10-18T12:21:01Z

Details

This PR implements logic not to display the green line for any new messages provided that the thread is scrolled to the latest message. It was achieved by taking into account the vertical offset of the user. The green line should still appear when the thread is scrolled to oldest messages.

Fixed Issues

$ #27456
PROPOSAL: #27456 (comment)

Tests

Log in on one device as user A, on another as user B
Open chat between users A and B
As user A, scroll down the chat to the latest messages
As user B, send a new message to user A
User A receives a new message, the green line indicating a new message doesn't appear
User A scrolls up to older messages
User B sends a new message
When the floating button appears and it's clicked, the thread is scrolled to newest messages and the new message has a green line above

Verify that no errors appear in the JS console

Offline tests

Same as Tests

QA Steps

Same as Tests

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

27456_android_native.mp4

Android: mWeb Chrome

27456_android_web.mp4

iOS: Native

27456_iOS_native.mp4

iOS: mWeb Safari

27456_iOS_web.mp4

MacOS: Chrome / Safari

27456_web.mp4

MacOS: Desktop

27456_desktop.mp4

github-actions · 2023-10-18T12:21:18Z

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

roksanaz · 2023-10-18T12:23:19Z

I have read the CLA Document and I hereby sign the CLA

barttom · 2023-10-18T13:37:51Z

src/pages/home/report/ReportActionsList.js

+                shouldDisplay = isCurrentMessageUnread && isNextMessageRead && isWithinVisibleThreshold;
+
+                if (shouldDisplay && !messageManuallyMarkedUnread) {
+                    shouldDisplay = reportAction.actorAccountID !== Report.getCurrentUserAccountID();


Should we ignore this condition if shoudlDisplay was set as false before? What is the purpose?

@barttom Yes, the previous logic worked the same (if shoudlDisplay was false before, it was also false for this condition as well), the code was like that:

App/src/pages/home/report/ReportActionsList.js

Lines 292 to 294 in 39d2a84

if (!messageManuallyMarkedUnread) {

shouldDisplay = shouldDisplay && reportAction.actorAccountID !== Report.getCurrentUserAccountID();

}

melvin-bot · 2023-10-20T07:41:35Z

@Santhosh-Sellavel Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

MonilBhavsar · 2023-10-26T07:47:32Z

@Santhosh-Sellavel 👋

Santhosh-Sellavel · 2023-10-26T07:49:33Z

Will get to it today eve. Sorry for the delay.

MonilBhavsar · 2023-10-26T08:04:51Z

No worries, thanks for the update!

MonilBhavsar · 2023-10-30T14:13:39Z

@Santhosh-Sellavel could you please share an update here, thank you

MonilBhavsar · 2023-10-30T14:16:28Z

Looks like Santhosh-Sellavel is ooo https://expensify.slack.com/archives/C02NK2DQWUX/p1698333756531649
I'm looking into it

situchan · 2023-10-30T14:18:20Z

I can help review today if needed

MonilBhavsar · 2023-10-30T14:20:37Z

Thanks, that would be great

situchan · 2023-10-30T17:42:40Z

Code looks good. One doubt if it's expected.

Login account A1 on device A, B
Login account A2 on device C
On A, scroll to old message, on B, scroll down to the latest message
A2 sends message to A1
New messages pill and green line shows on A though I already read message on B

Screen.Recording.2023-10-30.at.11.38.15.PM.mov

MonilBhavsar · 2023-10-30T18:30:50Z

Ha ha, a good case. Yes, that's expected. Assuming the message arrived on both devices at same time, and was marked as read on Mobile since user was scrolled down. We still want to make sure user sees the new message on web since they were scrolled up

situchan · 2023-10-30T19:25:56Z

Tests well on all platforms. @MonilBhavsar shall I complete reviewer checklist?

MonilBhavsar · 2023-10-30T20:10:12Z

Yes please, so we can ship it!!

situchan · 2023-10-30T20:23:27Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Included in web video

Android: mWeb Chrome

Included in desktop video

iOS: Native

Included in web video

iOS: mWeb Safari

Included in desktop video

MacOS: Chrome / Safari

when scrolled to latest message:

web-ios-android.mov

when scrolled to old message:

web-ios-android2.mov

MacOS: Desktop

desktop-mweb.mov

situchan

OSBotify · 2023-10-31T08:41:16Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-10-31T21:59:34Z

🚀 Deployed to staging by https://github.com/MonilBhavsar in version: 1.3.94-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-11-01T08:51:33Z

🚀 Deployed to staging by https://github.com/MonilBhavsar in version: 1.3.94-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

MonilBhavsar · 2023-11-01T16:49:26Z

We reverted the PR as it introduced two issues/blockers #30712 (comment)

Not taking visibiliity into account for manual unread case fixed one issue, but not the one with deleted case -

shouldDisplay = isCurrentMessageUnread && (!nextMessage || isNextMessageRead) && (messageManuallyMarkedUnread || isWithinVisibleThreshold);

We can update the approach and make a new PR cc @roksanaz

OSBotify · 2023-11-02T10:14:54Z

🚀 Deployed to production by https://github.com/Beamanator in version: 1.3.94-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-11-02T10:39:41Z

🚀 Deployed to staging by https://github.com/MonilBhavsar in version: 1.3.95-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-11-06T22:09:44Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.95-9 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Fix: 27456 green line

1ea93f7

roksanaz force-pushed the 27456-green-line branch from 128fd1e to 1ea93f7 Compare October 18, 2023 13:15

barttom reviewed Oct 18, 2023

View reviewed changes

Merge branch 'main' into 27456-green-line

2f9048a

roksanaz marked this pull request as ready for review October 20, 2023 07:41

roksanaz requested a review from a team as a code owner October 20, 2023 07:41

melvin-bot bot requested review from Santhosh-Sellavel and removed request for a team October 20, 2023 07:41

Merge branch 'main' into 27456-green-line

e5dc05e

MonilBhavsar self-requested a review October 27, 2023 10:08

MonilBhavsar mentioned this pull request Oct 27, 2023

[$500] mWeb-Conversation- Green line is shown creating request money in DM but not shown while split money #29376

Closed

6 tasks

situchan approved these changes Oct 30, 2023

View reviewed changes

MonilBhavsar approved these changes Oct 31, 2023

View reviewed changes

MonilBhavsar merged commit 36495e6 into Expensify:main Oct 31, 2023
14 checks passed

OSBotify mentioned this pull request Oct 31, 2023

Deploy Checklist: New Expensify 2023-10-31 #30662

Closed

97 tasks

erquhart mentioned this pull request Nov 1, 2023

[HOLD for payment 2023-11-13] [HOLD for payment 2023-11-09] [$500] Chat - Tapping "Mark as unread option" not showing green line above message #30684

Closed

6 tasks

grgia mentioned this pull request Nov 1, 2023

[HOLD for payment 2023-11-13] [HOLD for payment 2023-11-09] Unread message - When delete unread message green line blinks and goes to the next message #30696

Closed

6 tasks

MonilBhavsar mentioned this pull request Nov 1, 2023

[CP Staging] Revert "27456 Chat - The green line is displayed chaotically at the recipient" #30712

Merged

59 tasks

OSBotify mentioned this pull request Nov 2, 2023

Deploy Checklist: New Expensify 2023-11-02 #30752

Closed

melvin-bot bot mentioned this pull request Nov 2, 2023

[HOLD for payment 2023-12-12] [$1000] Chat - The green line is displayed chaotically at the recipient #27456

Closed

6 tasks

situchan mentioned this pull request Nov 2, 2023

[HOLD for payment 2023-11-09] [$500] A "New Messages" notification is shown when there is no new message #30359

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

27456 Chat - The green line is displayed chaotically at the recipient #29860

27456 Chat - The green line is displayed chaotically at the recipient #29860

roksanaz commented Oct 18, 2023

github-actions bot commented Oct 18, 2023 •

edited

Loading

roksanaz commented Oct 18, 2023

barttom Oct 18, 2023

roksanaz Oct 18, 2023

melvin-bot bot commented Oct 20, 2023

MonilBhavsar commented Oct 26, 2023

Santhosh-Sellavel commented Oct 26, 2023

MonilBhavsar commented Oct 26, 2023

MonilBhavsar commented Oct 30, 2023

MonilBhavsar commented Oct 30, 2023

situchan commented Oct 30, 2023

MonilBhavsar commented Oct 30, 2023

situchan commented Oct 30, 2023 •

edited

Loading

MonilBhavsar commented Oct 30, 2023

situchan commented Oct 30, 2023

MonilBhavsar commented Oct 30, 2023

situchan commented Oct 30, 2023

situchan left a comment

OSBotify commented Oct 31, 2023

OSBotify commented Oct 31, 2023

OSBotify commented Nov 1, 2023

MonilBhavsar commented Nov 1, 2023 •

edited

Loading

OSBotify commented Nov 2, 2023

OSBotify commented Nov 2, 2023

OSBotify commented Nov 6, 2023

	if (!messageManuallyMarkedUnread) {
	shouldDisplay = shouldDisplay && reportAction.actorAccountID !== Report.getCurrentUserAccountID();
	}

27456 Chat - The green line is displayed chaotically at the recipient #29860

27456 Chat - The green line is displayed chaotically at the recipient #29860

Conversation

roksanaz commented Oct 18, 2023

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

github-actions bot commented Oct 18, 2023 • edited Loading

roksanaz commented Oct 18, 2023

barttom Oct 18, 2023

Choose a reason for hiding this comment

roksanaz Oct 18, 2023

Choose a reason for hiding this comment

melvin-bot bot commented Oct 20, 2023

MonilBhavsar commented Oct 26, 2023

Santhosh-Sellavel commented Oct 26, 2023

MonilBhavsar commented Oct 26, 2023

MonilBhavsar commented Oct 30, 2023

MonilBhavsar commented Oct 30, 2023

situchan commented Oct 30, 2023

MonilBhavsar commented Oct 30, 2023

situchan commented Oct 30, 2023 • edited Loading

MonilBhavsar commented Oct 30, 2023

situchan commented Oct 30, 2023

MonilBhavsar commented Oct 30, 2023

situchan commented Oct 30, 2023

Reviewer Checklist

Screenshots/Videos

situchan left a comment

Choose a reason for hiding this comment

OSBotify commented Oct 31, 2023

OSBotify commented Oct 31, 2023

OSBotify commented Nov 1, 2023

MonilBhavsar commented Nov 1, 2023 • edited Loading

OSBotify commented Nov 2, 2023

OSBotify commented Nov 2, 2023

OSBotify commented Nov 6, 2023

github-actions bot commented Oct 18, 2023 •

edited

Loading

situchan commented Oct 30, 2023 •

edited

Loading

MonilBhavsar commented Nov 1, 2023 •

edited

Loading