Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/16184 base options selector refactoring #31606

Merged
merged 58 commits into from
Feb 26, 2024
Merged

Fix/16184 base options selector refactoring #31606

merged 58 commits into from
Feb 26, 2024

Commits on Nov 20, 2023

  1. BaseOptionsSelector refactoring

    @Piotrfj
    Piotrfj committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    ea2551d View commit details
    Browse the repository at this point in the history

  2. BaseOptionsSelector prettier

    @Piotrfj
    Piotrfj committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    bf38ece View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2023

  1. fix props

    @Piotrfj
    Piotrfj committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    368b708 View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2023

  1. bing back normal props to make code cleaner

    @Piotrfj
    Piotrfj committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    e3b8192 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' of https://github.com/Expensify/App into fix/1618… 

    …4-BaseOptionsSelector-refactoring

# Conflicts:
#	src/components/OptionsSelector/BaseOptionsSelector.js
    @Piotrfj
    Piotrfj committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    d7aaf8f View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2023

  1. clean code after pulled changes

    @Piotrfj
    Piotrfj committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    ca03827 View commit details
    Browse the repository at this point in the history

  2. prettier

    @Piotrfj
    Piotrfj committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    ebef308 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' of https://github.com/Expensify/App into fix/1618… 

    …4-BaseOptionsSelector-refactoring

# Conflicts:
#	src/components/OptionsSelector/BaseOptionsSelector.js
    @Piotrfj
    Piotrfj committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    5145589 View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2023

  1. fix lint issues

    @Piotrfj
    Piotrfj committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    70cd0a1 View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2023

  1. Merge branch 'main' into fix/16184-BaseOptionsSelector-refactoring

    @koko57
    koko57 committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    716d2a2 View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2023

  1. fix: fix linting errors

    @koko57
    koko57 committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    62d1b31 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into fix/16184-BaseOptionsSelector-refactoring

    @koko57
    koko57 committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    272633f View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2023

  1. Merge branch 'main' into fix/16184-BaseOptionsSelector-refactoring

    @koko57
    koko57 committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    e8d1fbc View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2023

  1. fix: fix autoFocus, ArrowKeyFocusManager, remove shouldDelayFocus

    @koko57
    koko57 committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    7a3a1d0 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into fix/16184-BaseOptionsSelector-refactoring

    @koko57
    koko57 committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    c0801ee View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2023

  1. fix: resolve conflicts

    @koko57
    koko57 committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    0f62e50 View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2023

  1. Merge branch 'main' into fix/16184-BaseOptionsSelector-refactoring

    @koko57
    koko57 committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    66fde97 View commit details
    Browse the repository at this point in the history

  2. fix: correct imports

    @koko57
    koko57 committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    6c8e063 View commit details
    Browse the repository at this point in the history

  3. fix: minor fix

    @koko57
    koko57 committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    13032d8 View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2023

  1. Merge branch 'main' into fix/16184-BaseOptionsSelector-refactoring

    @koko57
    koko57 committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    00e2a2b View commit details
    Browse the repository at this point in the history

  2. fix: wrap some functions in useCallback

    @koko57
    koko57 committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    15de776 View commit details
    Browse the repository at this point in the history

  3. fix: run prettier

    @koko57
    koko57 committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    594d72a View commit details
    Browse the repository at this point in the history

  4. fix: wrap functions in useCallback

    @koko57
    koko57 committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    4f9106a View commit details
    Browse the repository at this point in the history

  5. fix: minor fix

    @koko57
    koko57 committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    54e9ef0 View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2023

  1. fix: resolve conflicts

    @koko57
    koko57 committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    723e87e View commit details
    Browse the repository at this point in the history

  2. fix: restore latest changes to BaseOptionsSelector

    @koko57
    koko57 committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    fc1752c View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2023

  1. fix: resolve conflicts

    @koko57
    koko57 committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    a3217ec View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into fix/16184-BaseOptionsSelector-refactoring

    @koko57
    koko57 committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    163e377 View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2023

  1. Merge branch 'main' into fix/16184-BaseOptionsSelector-refactoring

    @koko57
    koko57 committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    e129ed0 View commit details
    Browse the repository at this point in the history

Commits on Dec 22, 2023

  1. fix: resolve conflicts

    @koko57
    koko57 committed Dec 22, 2023
    Configuration menu
    Copy the full SHA
    458f8b6 View commit details
    Browse the repository at this point in the history

Commits on Dec 28, 2023

  1. fix scrolling by arrow keys

    @Piotrfj
    Piotrfj committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    fbe28e9 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' of https://github.com/Expensify/App into fix/1618… 

    …4-BaseOptionsSelector-refactoring

# Conflicts:
#	src/components/OptionsSelector/BaseOptionsSelector.js
    @Piotrfj
    Piotrfj committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    8c2349d View commit details
    Browse the repository at this point in the history

Commits on Dec 29, 2023

  1. prettier

    @Piotrfj
    Piotrfj committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    0795f86 View commit details
    Browse the repository at this point in the history

Commits on Jan 2, 2024

  1. Merge branch 'main' of https://github.com/Expensify/App into fix/1618… 

    …4-BaseOptionsSelector-refactoring
    @Piotrfj
    Piotrfj committed Jan 2, 2024
    Configuration menu
    Copy the full SHA
    b6f4a8c View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2024

  1. fix performance test and scrolling

    @Piotrfj
    Piotrfj committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    1ad06dd View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' of https://github.com/Expensify/App into fix/1618… 

    …4-BaseOptionsSelector-refactoring
    @Piotrfj
    Piotrfj committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    3ad5847 View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2024

  1. Merge branch 'main' of https://github.com/Expensify/App into fix/1618… 

    …4-BaseOptionsSelector-refactoring

# Conflicts:
#	src/components/OptionsSelector/BaseOptionsSelector.js
    @Piotrfj
    Piotrfj committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    abf994b View commit details
    Browse the repository at this point in the history

  2. merge and refacotor new changes

    @Piotrfj
    Piotrfj committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    3adcfde View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' of https://github.com/Expensify/App into fix/1618… 

    …4-BaseOptionsSelector-refactoring
    @Piotrfj
    Piotrfj committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    6bb75ae View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2024

  1. fix lint

    @Piotrfj
    Piotrfj committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    c59ab5d View commit details
    Browse the repository at this point in the history

  2. fix lint

    @Piotrfj
    Piotrfj committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    fb4199e View commit details
    Browse the repository at this point in the history

  3. fix lint

    @Piotrfj
    Piotrfj committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    2120852 View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2024

  1. Merge branch 'main' of https://github.com/Expensify/App into fix/1618… 

    …4-BaseOptionsSelector-refactoring

# Conflicts:
#	src/components/OptionsSelector/BaseOptionsSelector.js
    @Piotrfj
    Piotrfj committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    febecc0 View commit details
    Browse the repository at this point in the history

  2. prettier

    @Piotrfj
    Piotrfj committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    7892399 View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2024

  1. Merge branch 'main' of https://github.com/Expensify/App into fix/1618… 

    …4-BaseOptionsSelector-refactoring
    @Piotrfj
    Piotrfj committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    0081e47 View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2024

  1. Merge branch 'main' of https://github.com/Expensify/App into fix/1618… 

    …4-BaseOptionsSelector-refactoring

# Conflicts:
#	src/components/OptionsSelector/BaseOptionsSelector.js
    @Piotrfj
    Piotrfj committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    81fd3f9 View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2024

  1. fix: resolve conflicts

    @koko57
    koko57 committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    69125ed View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2024

  1. fix: do not scrollToIndex when props.section is empty

    @koko57
    koko57 committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    31623d6 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into fix/16184-BaseOptionsSelector-refactoring

    @koko57
    koko57 committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    de356c9 View commit details
    Browse the repository at this point in the history

  3. fix: prettier

    @koko57
    koko57 committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    a7086cd View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2024

  1. fix: resolve conflicts

    @koko57
    koko57 committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    312e622 View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2024

  1. Merge branch 'main' of https://github.com/Expensify/App into fix/1618… 

    …4-BaseOptionsSelector-refactoring

# Conflicts:
#	src/components/OptionsSelector/BaseOptionsSelector.js
    @Piotrfj
    Piotrfj committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    0344bf8 View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2024

  1. fix document undefined

    @Piotrfj
    Piotrfj committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    6e34b98 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' of https://github.com/Expensify/App into fix/1618… 

    …4-BaseOptionsSelector-refactoring

# Conflicts:
#	src/components/OptionsSelector/BaseOptionsSelector.js
    @Piotrfj
    Piotrfj committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    797e698 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/fix/16184-BaseOptionsSelector-re… 

    …factoring' into fix/16184-BaseOptionsSelector-refactoring

# Conflicts:
#	src/components/OptionsSelector/BaseOptionsSelector.js
    @Piotrfj
    Piotrfj committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    6c2ec03 View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2024

  1. Merge branch 'main' into fix/16184-BaseOptionsSelector-refactoring

    @koko57
    koko57 committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    c451c99 View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2024

  1. Merge branch 'main' of https://github.com/Expensify/App into fix/1618… 

    …4-BaseOptionsSelector-refactoring

# Conflicts:
#	src/components/OptionsSelector/BaseOptionsSelector.js
    @Piotrfj
    Piotrfj committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    fd0302e View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/fix/16184-BaseOptionsSelector-re… 

    …factoring' into fix/16184-BaseOptionsSelector-refactoring
    @Piotrfj
    Piotrfj committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    dcc4ceb View commit details
    Browse the repository at this point in the history