Mark the latest report action from other users as unread #32958

dukenv0307 · 2023-12-13T06:09:48Z

Details

The app should mark the latest report action from other users as unread

Fixed Issues

$ #31748
PROPOSAL: #31748 (comment)

Tests

Launch the New Expensify app
Mark a chat where the latest message is not from you, as unread
Open the chat
Note that it shows the unread marker
Send a few messages to the chat
Return to LHN
Long press on the chat and mark it as unread
Open the chat
Verify that the unread indicator appears in the latest report action that doesn't come from the current user.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Launch the New Expensify app
Mark a chat where the latest message is not from you, as unread
Open the chat
Note that it shows the unread marker
Send a few messages to the chat
Return to LHN
Long press on the chat and mark it as unread
Open the chat
Verify that the unread indicator appears in the latest report action that doesn't come from the current user.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android-resize.mov

Android: mWeb Chrome

chrome-resize.mov

iOS: Native

ios-resize.mov

iOS: mWeb Safari

safari-resize.mov

MacOS: Chrome / Safari

web-resize.mov

MacOS: Desktop

desktop-resize.mov

melvin-bot · 2023-12-13T07:56:53Z

@mollfpr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/libs/actions/Report.ts

dukenv0307 · 2023-12-14T05:20:56Z

@MonilBhavsar Code updated. Please help review again.

MonilBhavsar

I saw the screenshot.
When marking message as unread in the chat. Looks like one is able to mark their own messages as unread. Why we don't follow similar logic as we do when marking as unread from LHN.

Also @mollfpr if you could please take a look

MonilBhavsar · 2023-12-15T16:57:54Z

src/libs/actions/Report.ts

+        if (current.actorAccountID !== currentUserAccountID) {
+            if (!latest || current.created > latest.created) {


Can be combined in one condition

mollfpr · 2023-12-16T13:44:54Z

When marking message as unread in the chat. Looks like one is able to mark their own messages as unread. Why we don't follow similar logic as we do when marking as unread from LHN.

I have the same thought on this. On Slack, when we unreadmark our message, it will put the marker on the message from another user before that message.

I think we should do the same when marking our own message from the popover.

dukenv0307 · 2023-12-18T09:20:45Z

@mollfpr @MonilBhavsar Just want to double confirm here

I have the same thought on this. On Slack, when we unreadmark our message, it will put the marker on the message from another user before that message.

If I mark my own message as unread, there should be two scenarios

If there is any message from another user created before the marked message( the one above in the Expensify UI ), find and mark that message.
There is no message from another user created before the marked message, find the first message from another created after the marked one ( the one below in the UI )

Please check the demo for more details

new-appoach-resize.mov

mollfpr · 2023-12-18T15:26:36Z

Here's the case of what I think when marking my message

Mark the previous message from the recipient if it exists
Mark the next message from the recipient there is no previous message
No mark if no message from recipient

MonilBhavsar · 2023-12-18T15:41:22Z

Let's not do that to keep things simplified? It could be interpreted as a bug more than a feature. Looks like in slack one is still able to mark the report as read

mollfpr · 2023-12-19T13:38:20Z

Let's not do that to keep things simplified? It could be interpreted as a bug more than a feature. Looks like in slack one is still able to mark the report as read

@MonilBhavsar Could you elaborate? Is the demo here enough?

dukenv0307 · 2023-12-22T07:56:20Z

@mollfpr @MonilBhavsar Friendly bump on this pending comment

MonilBhavsar · 2023-12-26T12:18:25Z

Hey team!
I mean when inside the chat in slack, one is able to mark their own messages as unread.
So we should also allow users marking their own message as unread when in chat.
When marked unread from LHN, let's mark message from another user as unread

Screen.Recording.2023-12-26.at.5.46.50.PM.mov

mollfpr · 2023-12-27T04:44:41Z

@MonilBhavsar, I think the result in this PR is already good enough.

Screen.Recording.2023-12-27.at.11.41.43.mp4

mollfpr · 2023-12-27T04:49:56Z

@dukenv0307 Let's finish this up, could you update the PR with the commented line? Thanks!

dukenv0307 · 2023-12-27T07:51:09Z

@mollfpr Updated.

mollfpr · 2023-12-28T19:31:56Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

32958.Android.mp4

Android: mWeb Chrome

32958.mWeb-Chrome.mp4

iOS: Native

32958.iOS.mp4

iOS: mWeb Safari

32958.mWeb-Safari.mp4

MacOS: Chrome / Safari

32958.Web.mp4

MacOS: Desktop

32958.Desktop.mp4

mollfpr

LGTM 👍

MonilBhavsar · 2023-12-29T05:38:46Z

Thanks!

mollfpr · 2023-12-29T05:39:44Z

@dukenv0307 We have invalid checklist, could you update it with the latedt one?

MonilBhavsar · 2023-12-29T05:41:30Z

The check was passing 😕

MonilBhavsar · 2023-12-29T05:42:03Z

@dukenv0307 could you please update the checklist and comment the difference here. thanks!

OSBotify · 2023-12-29T05:44:50Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-12-29T18:39:33Z

🚀 Deployed to staging by https://github.com/MonilBhavsar in version: 1.4.20-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-01-02T23:36:24Z

🚀 Deployed to production by https://github.com/marcaaron in version: 1.4.20-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

mark the latest report action from other users as unread

cd77713

dukenv0307 marked this pull request as ready for review December 13, 2023 07:56

dukenv0307 requested a review from a team as a code owner December 13, 2023 07:56

melvin-bot bot requested review from mollfpr and removed request for a team December 13, 2023 07:56

MonilBhavsar reviewed Dec 13, 2023

View reviewed changes

src/libs/actions/Report.ts Outdated Show resolved Hide resolved

src/libs/actions/Report.ts Outdated Show resolved Hide resolved

src/libs/actions/Report.ts Outdated Show resolved Hide resolved

find the latest report action from other users

04ff7ae

MonilBhavsar reviewed Dec 15, 2023

View reviewed changes

dukenv0307 added 2 commits December 27, 2023 14:43

Merge branch 'main' into fix/31748

d9835c8

merge main

d46864d

mollfpr approved these changes Dec 28, 2023

View reviewed changes

melvin-bot bot requested a review from MonilBhavsar December 28, 2023 19:39

MonilBhavsar approved these changes Dec 29, 2023

View reviewed changes

MonilBhavsar merged commit 5c5c862 into Expensify:main Dec 29, 2023
16 of 17 checks passed

github-actions bot mentioned this pull request Dec 29, 2023

Deploy Checklist: New Expensify 2023-12-29 #33772

Closed

28 tasks

melvin-bot bot mentioned this pull request Jan 2, 2024

[HOLD for payment 2024-02-01] [HOLD for payment 2024-01-31] [$250] Chat-No unread marker when chat with the latest text is from you and marked as unread from LHN #31748

Closed

6 tasks

bernhardoj mentioned this pull request Jan 4, 2024

[$500] LHN - Selecting Mark as unread not displaying chat in bold #33881

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Mark the latest report action from other users as unread #32958

Mark the latest report action from other users as unread #32958

dukenv0307 commented Dec 13, 2023 •

edited

Loading

melvin-bot bot commented Dec 13, 2023

dukenv0307 commented Dec 14, 2023

MonilBhavsar left a comment

MonilBhavsar Dec 15, 2023

mollfpr Dec 16, 2023

mollfpr commented Dec 16, 2023

dukenv0307 commented Dec 18, 2023 •

edited

Loading

mollfpr commented Dec 18, 2023

MonilBhavsar commented Dec 18, 2023

mollfpr commented Dec 19, 2023 •

edited

Loading

dukenv0307 commented Dec 22, 2023

MonilBhavsar commented Dec 26, 2023

mollfpr commented Dec 27, 2023

mollfpr commented Dec 27, 2023

dukenv0307 commented Dec 27, 2023

mollfpr commented Dec 28, 2023 •

edited

Loading

mollfpr left a comment

MonilBhavsar commented Dec 29, 2023

mollfpr commented Dec 29, 2023

MonilBhavsar commented Dec 29, 2023

MonilBhavsar commented Dec 29, 2023

OSBotify commented Dec 29, 2023

OSBotify commented Dec 29, 2023

OSBotify commented Jan 2, 2024

		if (current.actorAccountID !== currentUserAccountID) {
		if (!latest \|\| current.created > latest.created) {

Mark the latest report action from other users as unread #32958

Mark the latest report action from other users as unread #32958

Conversation

dukenv0307 commented Dec 13, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Dec 13, 2023

dukenv0307 commented Dec 14, 2023

MonilBhavsar left a comment

Choose a reason for hiding this comment

MonilBhavsar Dec 15, 2023

Choose a reason for hiding this comment

mollfpr Dec 16, 2023

Choose a reason for hiding this comment

mollfpr commented Dec 16, 2023

dukenv0307 commented Dec 18, 2023 • edited Loading

mollfpr commented Dec 18, 2023

MonilBhavsar commented Dec 18, 2023

mollfpr commented Dec 19, 2023 • edited Loading

dukenv0307 commented Dec 22, 2023

MonilBhavsar commented Dec 26, 2023

mollfpr commented Dec 27, 2023

mollfpr commented Dec 27, 2023

dukenv0307 commented Dec 27, 2023

mollfpr commented Dec 28, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

mollfpr left a comment

Choose a reason for hiding this comment

MonilBhavsar commented Dec 29, 2023

mollfpr commented Dec 29, 2023

MonilBhavsar commented Dec 29, 2023

MonilBhavsar commented Dec 29, 2023

OSBotify commented Dec 29, 2023

OSBotify commented Dec 29, 2023

OSBotify commented Jan 2, 2024

dukenv0307 commented Dec 13, 2023 •

edited

Loading

dukenv0307 commented Dec 18, 2023 •

edited

Loading

mollfpr commented Dec 19, 2023 •

edited

Loading

mollfpr commented Dec 28, 2023 •

edited

Loading