Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark the latest report action from other users as unread #32958

Merged
merged 4 commits into from
Dec 29, 2023
Merged

Mark the latest report action from other users as unread #32958

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cd77713
mark the latest report action from other users as unread
dukenv0307 Dec 13, 2023
04ff7ae
find the latest report action from other users
dukenv0307 Dec 14, 2023
d9835c8
Merge branch 'main' into fix/31748
dukenv0307 Dec 27, 2023
d46864d
merge main
dukenv0307 Dec 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions src/libs/actions/Report.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -938,8 +938,18 @@ function readNewestAction(reportID: string) {
* Sets the last read time on a report
*/
function markCommentAsUnread(reportID: string, reportActionCreated: string) {
// If no action created date is provided, use the last action's
const actionCreationTime = reportActionCreated || (allReports?.[reportID]?.lastVisibleActionCreated ?? DateUtils.getDBTime(0));
const reportActions = allReportActions?.[reportID];

// Find the latest report actions from other users
const latestReportActionFromOtherUsers = Object.values(reportActions ?? {}).reduce((latest: ReportAction | null, current: ReportAction) => {
if (current.actorAccountID !== currentUserAccountID && (!latest || current.created > latest.created)) {
return current;
}
return latest;
}, null);

// If no action created date is provided, use the last action's from other user
const actionCreationTime = reportActionCreated || (latestReportActionFromOtherUsers?.created ?? DateUtils.getDBTime(0));

// We subtract 1 millisecond so that the lastReadTime is updated to just before a given reportAction's created date
// For example, if we want to mark a report action with ID 100 and created date '2014-04-01 16:07:02.999' unread, we set the lastReadTime to '2014-04-01 16:07:02.998'
Expand Down
Loading