-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TS migration] Migrate 'WorkspaceInvite' page to TypeScript #35080
[TS migration] Migrate 'WorkspaceInvite' page to TypeScript #35080
Conversation
# Conflicts: # src/libs/OptionsListUtils.ts
# Conflicts: # src/pages/workspace/WorkspacePageWithSections.tsx
# Conflicts: # src/pages/workspace/WorkspaceInvitePage.tsx
@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2024-02-08.at.23.32.28.android.movAndroid: mWeb ChromeScreen.Recording.2024-02-08.at.23.35.39.android.chrome.moviOS: NativeScreen.Recording.2024-02-08.at.23.36.38.ios.moviOS: mWeb SafariScreen.Recording.2024-02-08.at.23.38.08.ios.safari.movMacOS: Chrome / SafariScreen.Recording.2024-02-08.at.23.24.03.web.movMacOS: DesktopScreen.Recording.2024-02-08.at.23.25.55.desktop.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
We did not find an internal engineer to review this PR, trying to assign a random engineer to #25207 as well as to this PR... Please reach out for help on Slack if no one gets assigned! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, though we need to resolve the merge conflicts. @VickyStash can you resolve those? Sorry no internal engineer got assigned to this for awhile.
# Conflicts: # src/pages/workspace/WorkspaceInvitePage.tsx
@blimpich Conflicts are resolved 👌 |
# Conflicts: # src/pages/workspace/WorkspaceInviteMessagePage.tsx
@blimpich resolved one more time 👌 |
Note: I'll be OOO Feb 10 - Feb 18 🌴 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/blimpich in version: 1.4.40-0 🚀
|
🚀 Deployed to production by https://github.com/mountiny in version: 1.4.40-5 🚀
|
// eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing | ||
workspaceInviteMessageDraft || |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@VickyStash , why did you prefer a OR ||
operator here instead of nullish ??
and silenced the type error ? any special reason ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently reviewing proposal for the issue #51655, where a contributor suggested to use nullish operator ??
instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it was to keep the logic consistent with the way it was before the TS migration.
As you can see props.workspaceInviteMessageDraft ||
was used, and since workspaceInviteMessageDraft
can be the empty string the change to ??
would affect the logic before the TS migration, we wanted to escape any side updates when it's changes the logic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh is it, thanks for the info 🙇
Details
[TS migration] Migrate 'WorkspaceInvite' page to TypeScript
Fixed Issues
$ #25207
PROPOSAL: N/A
Tests
Offline tests
N/A
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
android1.mp4
Android: mWeb Chrome
android_web1.mp4
iOS: Native
ios1.mp4
iOS: mWeb Safari
ios_web1.mp4
MacOS: Chrome / Safari
web1.mp4
MacOS: Desktop
desktop1.mp4