Refactor index files for Popover. #3558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see you marked this as a draft. Do you want an early review, or should I wait until you mark it ready for review again? |
|
You can wait, thanks 👍 |
|
Hey @HorusGoul, just took this off draft. Thanks for waiting! |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging in version: 1.0.68-5🚀
|
|
🚀 Deployed to production in version: 1.0.73-3🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
We realized that we don't really need the .native extension file because we expect the native platforms to have small screen sizes anyway. This fixes the problem for the linked issue, while simplifying our files.
Fixed Issues
Fixes #3347
Tests / Web QA
Tested On
My android environment has been finicky, so I'm going to leave the android testing to QA, (unless I can get it up and running before the review process is finished here).