[No QA] Conversion to Boolean #3896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickmurray47
suggested changes
Jul 7, 2021
src/libs/OptionsListUtils.js
Outdated
| @@ -215,7 +215,7 @@ function createOption(personalDetailList, report, draftComments, { | |||
| login: !hasMultipleParticipants ? personalDetail.login : null, | |||
| reportID: report ? report.reportID : null, | |||
| isUnread: report ? report.unreadActionCount > 0 : null, | |||
| hasDraftComment: reportDraftComment && reportDraftComment.length > 0, | |||
| hasDraftComment: !!reportDraftComment && reportDraftComment.length > 0, | |||
There was a problem hiding this comment.
I like !! but it would be better if this were a direct Boolean casting for clarity.
Suggested change
| hasDraftComment: !!reportDraftComment && reportDraftComment.length > 0, | |
| hasDraftComment: Boolean(reportDraftComment) && reportDraftComment.length > 0, |
There was a problem hiding this comment.
Another possible solution is _.size(reportDraftComment) > 0 (untested)
_.size should be safe to handle empty, null or undefined.
chiragsalian
approved these changes
Jul 7, 2021
|
Changes done and tested. |
nickmurray47
approved these changes
Jul 8, 2021
57 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Small change needed as ReportDraftComment could be '' which could lead to App Crash as we expect
true|falsehere. #3865 (comment)