Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[No QA] Conversion to Boolean #3896

Merged
merged 2 commits into from
Jul 8, 2021
Merged

[No QA] Conversion to Boolean #3896

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f02c69a
Conversion to Boolean
parasharrajat Jul 7, 2021
4215686
refactor
parasharrajat Jul 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/libs/OptionsListUtils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,7 @@ function createOption(personalDetailList, report, draftComments, {
login: !hasMultipleParticipants ? personalDetail.login : null,
reportID: report ? report.reportID : null,
isUnread: report ? report.unreadActionCount > 0 : null,
hasDraftComment: reportDraftComment && reportDraftComment.length > 0,
hasDraftComment: !!reportDraftComment && reportDraftComment.length > 0,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like !! but it would be better if this were a direct Boolean casting for clarity.

Suggested change
hasDraftComment: !!reportDraftComment && reportDraftComment.length > 0,
hasDraftComment: Boolean(reportDraftComment) && reportDraftComment.length > 0,

Copy link
Contributor

@chiragsalian chiragsalian Jul 7, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another possible solution is _.size(reportDraftComment) > 0 (untested)
_.size should be safe to handle empty, null or undefined.

keyForList: report ? String(report.reportID) : personalDetail.login,
searchText: getSearchText(report, personalDetailList),
isPinned: lodashGet(report, 'isPinned', false),
Expand Down