[CP Staging] Fix-#39361 Composer with emoji is expanded with an empty line after returning from Settings #39378

ishpaul777 · 2024-04-01T21:10:21Z

Details

Fixed Issues

$ #39361
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Go to newdot
Go to any chat
Enter an emoji
Go to Profile settings next to FAB
Return to Chat tab

Offline tests

QA Steps

Verify that no errors appear in the JS console
Same as test steps

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Screen.Recording.2024-04-02.at.3.16.41.AM.mov

Android: mWeb Chrome

Screen.Recording.2024-04-02.at.3.14.08.AM.mov

iOS: Native

Screen.Recording.2024-04-02.at.2.46.03.AM.mov

iOS: mWeb Safari

Screen.Recording.2024-04-02.at.2.42.41.AM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-04-02.at.2.37.50.AM.mov

MacOS: Desktop

Screen.Recording.2024-04-02.at.3.07.51.AM-1.mov

melvin-bot · 2024-04-01T21:48:28Z

@Pujan92 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

allroundexperts · 2024-04-01T21:58:37Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

allroundexperts · 2024-04-01T22:16:09Z

src/pages/home/ReportScreen.tsx

@@ -102,7 +102,7 @@ type ReportScreenProps = OnyxHOCProps & CurrentReportIDContextValue & ReportScre
 function getReportID(route: ReportScreenNavigationProps['route']): string {
    // The report ID is used in an onyx key. If it's an empty string, onyx will return
    // a collection instead of an individual report.
-    return String(route.params?.reportID || '');
+    return String(route.params?.reportID || 0);


@ishpaul777 Why is this change required? Shouldn't the previous code return the same output as well?

#38955 (comment)

allroundexperts · 2024-04-01T22:20:11Z

BUG

Screen.Recording.2024-04-02.at.3.17.03.AM.mov

ishpaul777 · 2024-04-01T22:24:02Z

Can't reproduce, did i follow the steps correctly

Screen.Recording.2024-04-02.at.3.52.37.AM.mov

allroundexperts · 2024-04-01T22:27:10Z

@ishpaul777 Try with a workspace chat.

ishpaul777 · 2024-04-01T22:29:08Z

can't reproduce either

Screen.Recording.2024-04-02.at.3.57.52.AM.mov

allroundexperts · 2024-04-01T22:31:17Z

Super weird. Let me dig into it.

allroundexperts · 2024-04-01T22:49:19Z

Logging out and logging in again fixed this!

allroundexperts · 2024-04-01T22:54:18Z

Although, this is happening on all the devices where I am signed in with the account. It seems like that when I come back on the screen, it doesn't fetch the data. After removing the changes in this PR, it starts to work 🤔

allroundexperts · 2024-04-01T23:00:51Z

Okay. Confirmed that this is due to the changes of this PR. @ishpaul777 Try changing the screens quickly.

ishpaul777 · 2024-04-01T23:11:23Z

i can't repro even now, but can you help confirming which specific change is triggering this bug, is it this https://github.com/Expensify/App/pull/39378/files#r1546910380 one if yes then the revert of original PR will not work 🤔

logically speaking const reportIDFromRoute = route?.params?.reportID ?? ''; can't trigger it becuase its the same as before and if we revert the offending PR that will also include this change

ishpaul777 · 2024-04-01T23:19:08Z

@allroundexperts Does the bug goes away after resign reliably, it could be because of previous onyx collection wrongly fetched becuase no id was provided 🤔

allroundexperts · 2024-04-01T23:22:31Z

@allroundexperts Does the bug goes away after resign reliably, it could be because of previous onyx collection wrongly fetched becuase no id was provided 🤔

It reappeared after I logged in again.

allroundexperts · 2024-04-01T23:25:22Z

Specifically, removing 0 and adding '' here fixes the issue.

allroundexperts · 2024-04-01T23:27:33Z

Yep, confirmed the above. This does not fix the issue reliably. I would suggest to do a proper RCA on this and fix it from the root. Adding the fix hastily would just introduce more regressions.

ishpaul777 · 2024-04-01T23:39:04Z

i found this explaination correct #38955 (comment), and believe adding a '' instead of 0 directly here was a mistake in first place

allroundexperts · 2024-04-01T23:40:06Z

i found this explaination correct #38955 (comment), and believe adding a '' instead of 0 directly here was a mistake in first place

Have you managed to reproduce above?

ishpaul777 · 2024-04-01T23:41:29Z

nope :(

Screen.Recording.2024-04-02.at.4.56.00.AM.mov

allroundexperts · 2024-04-01T23:43:31Z

nope :(

Screen.Recording.2024-04-02.at.4.56.00.AM.mov

Maybe try repeating the opening and closing steps several times. Adding emoji is not important. Just try to open and close the profile page 5-6 times quickly.

ishpaul777 · 2024-04-01T23:46:16Z

tried that also

Screen.Recording.2024-04-02.at.5.14.51.AM.mov

allroundexperts · 2024-04-01T23:48:04Z

Nice. This seems like tough bug to catch. @marcaaron By any chance, can you try to reproduce?

ishpaul777 · 2024-04-01T23:57:35Z

@ marcaaron slack status says he is not around. @marcochavezf can you please help here reproducing

marcochavezf · 2024-04-02T00:22:06Z

I tested quickly and I haven't been able to reproduce the bug reported here:

Screen.Recording.2024-04-01.at.6.08.02.p.m.mov

Yep, confirmed the above. This does not fix the issue reliably. I would suggest to do a proper RCA on this and fix it from the root. Adding the fix hastily would just introduce more regressions.

@allroundexperts are you able to reproduce it constantly? If we can confirm this introduces a bug (even if it's intermittent) I think we should revert to fix the deploy blocker and I agree we should do a proper RCA

ishpaul777 · 2024-04-02T00:26:24Z

I think we should revert to fix the deploy blocker

i dont think that will help either the change that seems to trigger the bug #39378 (comment) will also be in the revert @allroundexperts could you confirm please 🤔

marcochavezf · 2024-04-02T00:55:03Z

Given that deploy blockers are time-sensitive and the checklist is not completed because we don't feel confident about the solution, I will proceed with the revert.

I think we should revert to fix the deploy blocker

i dont think that will help either the change that seems to trigger the bug #39378 (comment) will also be in the revert @allroundexperts could you confirm please 🤔

You can create another PR and include in the RCA why the bug will still present, meanwhile let's unblock the deploy, sorry 🙇🏽

ishpaul777 added 5 commits March 28, 2024 04:12

Merge branch 'main' of https://github.com/ishpaul777/App

89a9f65

Merge branch 'main' of https://github.com/ishpaul777/App

ea86d73

Merge branch 'main' of https://github.com/ishpaul777/App

1a7adb5

Merge branch 'main' of https://github.com/ishpaul777/App

c877ebd

fixes composer wobbling for new chat

97c20b1

ishpaul777 marked this pull request as ready for review April 1, 2024 21:48

ishpaul777 requested a review from a team as a code owner April 1, 2024 21:48

melvin-bot bot requested review from Pujan92 and removed request for a team April 1, 2024 21:48

ishpaul777 mentioned this pull request Apr 1, 2024

[$500] Web - Chat - Composer with emoji is expanded with an empty line after expanding the composer #39361

Closed

6 tasks

marcaaron changed the title ~~Fix-#39361 Composer with emoji is expanded with an empty line after returning from Settings~~ [CP Staging] Fix-#39361 Composer with emoji is expanded with an empty line after returning from Settings Apr 1, 2024

marcaaron requested review from allroundexperts and removed request for Pujan92 April 1, 2024 21:57

allroundexperts reviewed Apr 1, 2024

View reviewed changes

marcochavezf mentioned this pull request Apr 2, 2024

[CP Staging] Revert "fixes "Skeleton is displayed when navigating to a transaction thread created offline"" #39377

Merged

48 tasks

ishpaul777 closed this Apr 4, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CP Staging] Fix-#39361 Composer with emoji is expanded with an empty line after returning from Settings #39378

[CP Staging] Fix-#39361 Composer with emoji is expanded with an empty line after returning from Settings #39378

ishpaul777 commented Apr 1, 2024 •

edited

Loading

melvin-bot bot commented Apr 1, 2024

allroundexperts commented Apr 1, 2024

allroundexperts Apr 1, 2024

ishpaul777 Apr 1, 2024

allroundexperts commented Apr 1, 2024

ishpaul777 commented Apr 1, 2024

allroundexperts commented Apr 1, 2024

ishpaul777 commented Apr 1, 2024 •

edited

Loading

allroundexperts commented Apr 1, 2024

allroundexperts commented Apr 1, 2024

allroundexperts commented Apr 1, 2024

allroundexperts commented Apr 1, 2024

ishpaul777 commented Apr 1, 2024 •

edited

Loading

ishpaul777 commented Apr 1, 2024

allroundexperts commented Apr 1, 2024

allroundexperts commented Apr 1, 2024

allroundexperts commented Apr 1, 2024

ishpaul777 commented Apr 1, 2024

allroundexperts commented Apr 1, 2024

ishpaul777 commented Apr 1, 2024

allroundexperts commented Apr 1, 2024

ishpaul777 commented Apr 1, 2024

allroundexperts commented Apr 1, 2024

ishpaul777 commented Apr 1, 2024 •

edited

Loading

marcochavezf commented Apr 2, 2024

ishpaul777 commented Apr 2, 2024 •

edited

Loading

marcochavezf commented Apr 2, 2024

[CP Staging] Fix-#39361 Composer with emoji is expanded with an empty line after returning from Settings #39378

[CP Staging] Fix-#39361 Composer with emoji is expanded with an empty line after returning from Settings #39378

Conversation

ishpaul777 commented Apr 1, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Apr 1, 2024

allroundexperts commented Apr 1, 2024

Reviewer Checklist

Screenshots/Videos

allroundexperts Apr 1, 2024

Choose a reason for hiding this comment

ishpaul777 Apr 1, 2024

Choose a reason for hiding this comment

allroundexperts commented Apr 1, 2024

ishpaul777 commented Apr 1, 2024

allroundexperts commented Apr 1, 2024

ishpaul777 commented Apr 1, 2024 • edited Loading

allroundexperts commented Apr 1, 2024

allroundexperts commented Apr 1, 2024

allroundexperts commented Apr 1, 2024

allroundexperts commented Apr 1, 2024

ishpaul777 commented Apr 1, 2024 • edited Loading

ishpaul777 commented Apr 1, 2024

allroundexperts commented Apr 1, 2024

allroundexperts commented Apr 1, 2024

allroundexperts commented Apr 1, 2024

ishpaul777 commented Apr 1, 2024

allroundexperts commented Apr 1, 2024

ishpaul777 commented Apr 1, 2024

allroundexperts commented Apr 1, 2024

ishpaul777 commented Apr 1, 2024

allroundexperts commented Apr 1, 2024

ishpaul777 commented Apr 1, 2024 • edited Loading

marcochavezf commented Apr 2, 2024

ishpaul777 commented Apr 2, 2024 • edited Loading

marcochavezf commented Apr 2, 2024

ishpaul777 commented Apr 1, 2024 •

edited

Loading

ishpaul777 commented Apr 1, 2024 •

edited

Loading

ishpaul777 commented Apr 1, 2024 •

edited

Loading

ishpaul777 commented Apr 1, 2024 •

edited

Loading

ishpaul777 commented Apr 2, 2024 •

edited

Loading