Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CP Staging] Fix-#39361 Composer with emoji is expanded with an empty line after returning from Settings #39378

Closed
wants to merge 5 commits into from
Closed

[CP Staging] Fix-#39361 Composer with emoji is expanded with an empty line after returning from Settings #39378

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
89a9f65
Merge branch 'main' of https://github.com/ishpaul777/App
ishpaul777 Mar 27, 2024
ea86d73
Merge branch 'main' of https://github.com/ishpaul777/App
ishpaul777 Mar 28, 2024
1a7adb5
Merge branch 'main' of https://github.com/ishpaul777/App
ishpaul777 Mar 29, 2024
c877ebd
Merge branch 'main' of https://github.com/ishpaul777/App
ishpaul777 Apr 1, 2024
97c20b1
fixes composer wobbling for new chat
ishpaul777 Apr 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/pages/home/ReportScreen.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ type ReportScreenProps = OnyxHOCProps & CurrentReportIDContextValue & ReportScre
function getReportID(route: ReportScreenNavigationProps['route']): string {
// The report ID is used in an onyx key. If it's an empty string, onyx will return
// a collection instead of an individual report.
return String(route.params?.reportID || '');
return String(route.params?.reportID || 0);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ishpaul777 Why is this change required? Shouldn't the previous code return the same output as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#38955 (comment)

}

/**
Expand Down Expand Up @@ -143,7 +143,7 @@ function ReportScreen({
const styles = useThemeStyles();
const {translate} = useLocalize();
const {isSmallScreenWidth} = useWindowDimensions();
const reportIDFromRoute = getReportID(route);
const reportIDFromRoute = route?.params?.reportID ?? '';
const reportActionIDFromRoute = route?.params?.reportActionID ?? '';
const isFocused = useIsFocused();
const prevIsFocused = usePrevious(isFocused);
Expand Down
Loading