[#Wave-Control: Add NetSuite] Add Support for NetSuite Token Input #44661

mananjadhav · 2024-06-29T21:50:10Z

Details

Fixed Issues

$ #43434
PROPOSAL:

Tests

Prerequisite:

Have Accounting enabled for a workspace.
Have NetSuite integration enabled.

Test Steps

Open the App
Go to the Workspace Settings > Choose your workspace that has Accounting enabled.
Click on Accounting menu.
Click on the Connect button next to NetSuite.
You should see the the step form with steps 1-5.
For the first four steps you should see static content based on the design doc and the content doc
On the step 5, you should see the form with three inputs - NetSuite Account ID, Token ID and Token Secret.
Below the NetSuite Account ID you should see the description text for the field.
Enter the for the NetSuite account info and click on Confirm.
Verify you're redirected to the Policy Accounting page.
After sometime you should be able to see the NetSuite account integrated.
Note: While this PR is made, the connection sync in progress doesn't show up for NetSuite. This is not a part of the current PR, hence you might see a delay in the connection info.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

…ken-input

mananjadhav · 2024-06-29T22:39:34Z

Uploading the demo video. The API is failing and I'll finish the checklist once that's done.

web-netsuite-token-input-ui.mov

mananjadhav · 2024-06-29T22:50:45Z

src/components/ConnectionLayout.tsx

@@ -60,6 +60,12 @@ type ConnectionLayoutProps = {

    /** Name of the current connection */
    connectionName: ConnectionName;
+
+    /** Block the screen when the connection is not empty */
+    reverseConnectionEmptyCheck?: boolean;


For the Token Input we want that the connection should be empty and it should be blocked when connection is not empty. I couldn't come up with a better name.

How about `isForEmptyConnection

src/components/ConnectionLayout.tsx

src/components/InteractiveStepSubHeader.tsx

src/languages/en.ts

shubham1206agra · 2024-07-03T08:27:36Z

src/pages/workspace/accounting/netsuite/NetSuiteTokenInput/NetSuiteTokenInputPage.tsx

+    const ref: ForwardedRef<InteractiveStepSubHeaderHandle> = useRef(null);
+
+    const submit = () => {
+        Navigation.goBack(ROUTES.POLICY_ACCOUNTING.getRoute(policyID));


Suggested change

Navigation.goBack(ROUTES.POLICY_ACCOUNTING.getRoute(policyID));

Navigation.goBack();

@mananjadhav This is again causing navigation issues.

yuwenmemon · 2024-07-03T17:10:16Z

Looking at the video - after making the connection can we optimistically update the onyx data for NetSuite to indicate that it's syncing? From there, the IS job to make the connection will send onyx updates with the status of the sync.

…ken-input

mananjadhav · 2024-07-03T18:03:48Z

Looking at the video - after making the connection can we optimistically update the onyx data for NetSuite to indicate that it's syncing? From there, the IS job to make the connection will send onyx updates with the status of the sync.

But I don't see any IS job or the Onyx data being updated. If you see the Last sync doesn't show the timestampt also.

Screen.Recording.2024-07-03.at.11.32.50.PM.mov

…ken-input

mananjadhav · 2024-07-03T18:53:13Z

I removed all videos containing credentials. Adding these videos with secure entry.

web-netsuite-steps.mov

web-netsuite-form.mov

shubham1206agra · 2024-07-04T02:40:02Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Contains sensitive info, so see this in slack thread below.

https://expensify.slack.com/archives/C06ML6X0W9L/p1720060654300349

src/CONST.ts

Co-authored-by: Shubham Agrawal <58412969+shubham1206agra@users.noreply.github.com>

yuwenmemon

One comment but will consider it a NAB and we can fix in a follow-up

yuwenmemon · 2024-07-04T17:28:30Z

src/components/ConnectionLayout.tsx

@@ -60,6 +60,12 @@ type ConnectionLayoutProps = {

    /** Name of the current connection */
    connectionName: ConnectionName;
+
+    /** Block the screen when the connection is not empty */
+    reverseConnectionEmptyCheck?: boolean;


How about `isForEmptyConnection

mananjadhav · 2024-07-04T17:39:46Z

How about isForEmptyConnection.

Thanks for merging. I'll update in one my other PRs.

OSBotify · 2024-07-04T17:40:29Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-07-08T09:57:58Z

🚀 Deployed to staging by https://github.com/yuwenmemon in version: 9.0.5-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-08T10:54:21Z

🚀 Deployed to staging by https://github.com/yuwenmemon in version: 9.0.5-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2024-07-10T11:04:56Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.0.5-13 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-15T20:23:20Z

🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.6-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

mananjadhav added 20 commits June 28, 2024 04:02

feat: added page for token input

a020d54

feat: added connection layout

b977ffd

Merge branch 'main' of github.com:mananjadhav/App into mj-netsuite-to…

9a307a4

…ken-input

feat: ui setup for form steps

3f847a4

fix: added form messages

25498ed

Merge branch 'main' of github.com:mananjadhav/App into mj-netsuite-to…

deaf512

…ken-input

fix: allow dynamic header

3f6bdee

feat: customize back handler and clean up

4c3dbe7

feat: added step setup

40f66c5

refactor: styling and prettier fixes

57178a3

feat: added input form

05f538d

fix: design and spacing updates

ec16dbe

feat: form submission

f5d8358

refactor: run prettier

e7cd84d

feat: connect to api

cc9039a

fix: update api calls

d113252

refactor: run prettier

22f7ae6

feat: added helper text

69463f3

fix: translation

08c30e0

refactor: change prop name

7edd2b3

mananjadhav changed the title ~~[#Wave-Control: Add NetSuite] Add Support for NetSuite Token Input~~ [Hold #43442][#Wave-Control: Add NetSuite] Add Support for NetSuite Token Input Jun 29, 2024

refactor: replace for html

73fae35

mananjadhav changed the title ~~[Hold #43442][#Wave-Control: Add NetSuite] Add Support for NetSuite Token Input~~ [Hold API][#Wave-Control: Add NetSuite] Add Support for NetSuite Token Input Jun 29, 2024

refactor: run prettier

8edf5fc

refactor: remove unwanted code

d54e38d

mananjadhav commented Jun 29, 2024

View reviewed changes

src/components/ConnectionLayout.tsx Show resolved Hide resolved

mananjadhav commented Jun 29, 2024

View reviewed changes

src/components/InteractiveStepSubHeader.tsx Outdated Show resolved Hide resolved

mananjadhav commented Jun 29, 2024

View reviewed changes

src/languages/en.ts Show resolved Hide resolved

mananjadhav added 2 commits July 3, 2024 03:16

refactor: run prettier

6367eff

fix: missing keys

3fce9c1

yuwenmemon assigned mananjadhav Jul 3, 2024

shubham1206agra reviewed Jul 3, 2024

View reviewed changes

mananjadhav added 2 commits July 3, 2024 23:12

Merge branch 'main' of github.com:mananjadhav/App into mj-netsuite-to…

919c27a

…ken-input

fix: gback

0e0d04c

mananjadhav added 5 commits July 3, 2024 23:49

refactor: cleanup

2c9f2da

Merge branch 'main' of github.com:mananjadhav/App into mj-netsuite-to…

2f73185

…ken-input

refactor: run prettier

82388e2

fix: remove optimisticdata

6da7961

fix: add back optimistic data

7753420

shubham1206agra reviewed Jul 4, 2024

View reviewed changes

src/CONST.ts Outdated Show resolved Hide resolved

shubham1206agra approved these changes Jul 4, 2024

View reviewed changes

shubham1206agra reviewed Jul 4, 2024

View reviewed changes

src/CONST.ts Outdated Show resolved Hide resolved

fix: remove unwanted change

7bc2813

Co-authored-by: Shubham Agrawal <58412969+shubham1206agra@users.noreply.github.com>

yuwenmemon approved these changes Jul 4, 2024

View reviewed changes

yuwenmemon merged commit 3e4d14f into Expensify:main Jul 4, 2024
15 checks passed

github-actions bot mentioned this pull request Jul 8, 2024

Deploy Checklist: New Expensify 2024-07-08 #44947

Closed

86 tasks

lanitochka17 mentioned this pull request Jul 8, 2024

NetSuite - Infinite loading shows when trying to connect #45010

Closed

6 tasks

melvin-bot bot mentioned this pull request Jul 10, 2024

[HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [HOLD for payment 2024-07-10] [#Wave-Control: Add NetSuite] Add Support for NetSuite Token Input #43434

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[#Wave-Control: Add NetSuite] Add Support for NetSuite Token Input #44661

[#Wave-Control: Add NetSuite] Add Support for NetSuite Token Input #44661

mananjadhav commented Jun 29, 2024 •

edited

Loading

mananjadhav commented Jun 29, 2024

mananjadhav Jun 29, 2024

yuwenmemon Jul 4, 2024

shubham1206agra Jul 3, 2024

mananjadhav Jul 3, 2024

yuwenmemon commented Jul 3, 2024

mananjadhav commented Jul 3, 2024

mananjadhav commented Jul 3, 2024

shubham1206agra commented Jul 4, 2024

yuwenmemon left a comment

yuwenmemon Jul 4, 2024

mananjadhav commented Jul 4, 2024

OSBotify commented Jul 4, 2024

OSBotify commented Jul 8, 2024

OSBotify commented Jul 8, 2024

OSBotify commented Jul 10, 2024

OSBotify commented Jul 15, 2024

	Navigation.goBack(ROUTES.POLICY_ACCOUNTING.getRoute(policyID));
	Navigation.goBack();

[#Wave-Control: Add NetSuite] Add Support for NetSuite Token Input #44661

[#Wave-Control: Add NetSuite] Add Support for NetSuite Token Input #44661

Conversation

mananjadhav commented Jun 29, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

mananjadhav commented Jun 29, 2024

mananjadhav Jun 29, 2024

Choose a reason for hiding this comment

yuwenmemon Jul 4, 2024

Choose a reason for hiding this comment

shubham1206agra Jul 3, 2024

Choose a reason for hiding this comment

mananjadhav Jul 3, 2024

Choose a reason for hiding this comment

yuwenmemon commented Jul 3, 2024

mananjadhav commented Jul 3, 2024

mananjadhav commented Jul 3, 2024

shubham1206agra commented Jul 4, 2024

Reviewer Checklist

Screenshots/Videos

yuwenmemon left a comment

Choose a reason for hiding this comment

yuwenmemon Jul 4, 2024

Choose a reason for hiding this comment

mananjadhav commented Jul 4, 2024

OSBotify commented Jul 4, 2024

OSBotify commented Jul 8, 2024

OSBotify commented Jul 8, 2024

OSBotify commented Jul 10, 2024

OSBotify commented Jul 15, 2024

mananjadhav commented Jun 29, 2024 •

edited

Loading