-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#Wave-Control: Add NetSuite] Add Support for NetSuite Token Input #44661
Merged
yuwenmemon
merged 48 commits into
Expensify:main
from
mananjadhav:mj-netsuite-token-input
Jul 4, 2024
Merged
Changes from all commits
Commits
Show all changes
48 commits
Select commit
Hold shift + click to select a range
a020d54
feat: added page for token input
mananjadhav b977ffd
feat: added connection layout
mananjadhav 9a307a4
Merge branch 'main' of github.com:mananjadhav/App into mj-netsuite-to…
mananjadhav 3f847a4
feat: ui setup for form steps
mananjadhav 25498ed
fix: added form messages
mananjadhav deaf512
Merge branch 'main' of github.com:mananjadhav/App into mj-netsuite-to…
mananjadhav 3f6bdee
fix: allow dynamic header
mananjadhav 4c3dbe7
feat: customize back handler and clean up
mananjadhav 40f66c5
feat: added step setup
mananjadhav 57178a3
refactor: styling and prettier fixes
mananjadhav 05f538d
feat: added input form
mananjadhav ec16dbe
fix: design and spacing updates
mananjadhav f5d8358
feat: form submission
mananjadhav e7cd84d
refactor: run prettier
mananjadhav cc9039a
feat: connect to api
mananjadhav d113252
fix: update api calls
mananjadhav 22f7ae6
refactor: run prettier
mananjadhav 69463f3
feat: added helper text
mananjadhav 08c30e0
fix: translation
mananjadhav 7edd2b3
refactor: change prop name
mananjadhav 73fae35
refactor: replace for html
mananjadhav 8edf5fc
refactor: run prettier
mananjadhav d54e38d
refactor: remove unwanted code
mananjadhav d4b9f35
Merge branch 'main' of github.com:mananjadhav/App into mj-netsuite-to…
mananjadhav 712aae9
refactor: run prettier
mananjadhav 9807cab
refactor: remove setstate and use ref
mananjadhav 0d551f2
refactor: style fixes
mananjadhav b8c3790
Merge branch 'main' of github.com:mananjadhav/App into mj-netsuite-to…
mananjadhav 7b721f3
refactor: run prettier
mananjadhav 9cadc4b
refactor: remove unused var
mananjadhav c61be5b
refactor: rename params
mananjadhav 82efe3d
Merge branch 'main' of github.com:mananjadhav/App into mj-netsuite-to…
mananjadhav f794a89
fix: styling and type errors
mananjadhav 267d32a
Merge branch 'main' of github.com:mananjadhav/App into mj-netsuite-to…
mananjadhav f777abc
Merge branch 'main' of github.com:mananjadhav/App into mj-netsuite-to…
mananjadhav 4526f4f
fix: broken const file
mananjadhav 385bfda
Merge branch 'main' of github.com:mananjadhav/App into mj-netsuite-to…
mananjadhav f10ee55
fix: broken const file
mananjadhav 6367eff
refactor: run prettier
mananjadhav 3fce9c1
fix: missing keys
mananjadhav 919c27a
Merge branch 'main' of github.com:mananjadhav/App into mj-netsuite-to…
mananjadhav 0e0d04c
fix: gback
mananjadhav 2c9f2da
refactor: cleanup
mananjadhav 2f73185
Merge branch 'main' of github.com:mananjadhav/App into mj-netsuite-to…
mananjadhav 82388e2
refactor: run prettier
mananjadhav 6da7961
fix: remove optimisticdata
mananjadhav 7753420
fix: add back optimistic data
mananjadhav 7bc2813
fix: remove unwanted change
mananjadhav File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
type ConnectPolicyToNetSuiteParams = { | ||
policyID: string; | ||
netSuiteAccountID: string; | ||
netSuiteTokenID: string; | ||
netSuiteTokenSecret: string; | ||
}; | ||
|
||
export default ConnectPolicyToNetSuiteParams; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the Token Input we want that the connection should be empty and it should be blocked when connection is not empty. I couldn't come up with a better name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about `isForEmptyConnection