Remove workspace growl message that is no longer necessary #4508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelbettner
approved these changes
Aug 10, 2021
|
@TomatoToaster it looks fine, but there are conflicts. |
|
Ah yeah this can be closed out, Tim took care of it in this PR: #4533 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@joelbettner, please review when you get the chance.
Details
Removes this growl message since it's no longer needed. I couldn't find a translation for it which probably explains why it says
workspace.new.successMessageinstead of the actual thing.Fixed Issues
$ https://github.com/Expensify/Expensify/issues/173338
Tests
Same as Web QA done locally
QA Steps
Log into an account on the free plan beta
Go to the + on the bottom left and create a new workspace
Verify that when you are brought to this page, you do NOT see the success growl like this:
BAD:
Tested On