-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always auto name and create new workspaces from oldDot #4533
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM pending the spanish translation. Feel free to merge when that's approved or this goes off hold.
Sorry Bondy for the pings, was trying to get pullerbear to pick someone else... |
Ok @TomatoToaster |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a couple of NAB otherwise looks good to my newbie-app-eyes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Self merging since tests are passing and this is approved. |
@TomatoToaster pinging you for review since we discussed this PR.
Details
Removes the
workspace/new
page completely since we always want to auto name and create workspaces for N6.Slack thread for more context, but in N6 we always want to auto name and create the workspace for the user, so the
workspace/new
page is no longer needed.Also removed the success growl per this issue.
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/173349
$ https://github.com/Expensify/Expensify/issues/173338
Tests
Tested through oldDot Inbox flow.
Get Expensify Card
then clickSubmit
/workspace/<policyId>/card
QA Steps
Same as tests
Tested On
Web
autoNameAndCreate.mov