Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always auto name and create new workspaces from oldDot #4533

Merged
merged 7 commits into from
Aug 11, 2021

Conversation

timszot
Copy link
Contributor

@timszot timszot commented Aug 10, 2021

@TomatoToaster pinging you for review since we discussed this PR.

Details

Removes the workspace/new page completely since we always want to auto name and create workspaces for N6.
Slack thread for more context, but in N6 we always want to auto name and create the workspace for the user, so the workspace/new page is no longer needed.

Also removed the success growl per this issue.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/173349
$ https://github.com/Expensify/Expensify/issues/173338

Tests

Tested through oldDot Inbox flow.

  1. Log into an account on oldDot and show all hidden inbox cards
  2. Find the inbox card below and select only Get Expensify Card then click Submit
    image
  3. Verify you are taken to /workspace/<policyId>/card
    image

QA Steps

Same as tests

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Web

autoNameAndCreate.mov

@timszot timszot requested a review from a team as a code owner August 10, 2021 21:39
@timszot timszot self-assigned this Aug 10, 2021
@MelvinBot MelvinBot requested review from bondydaa and removed request for a team August 10, 2021 21:40
TomatoToaster
TomatoToaster previously approved these changes Aug 10, 2021
Copy link
Contributor

@TomatoToaster TomatoToaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM pending the spanish translation. Feel free to merge when that's approved or this goes off hold.

@timszot timszot requested review from a team and removed request for bondydaa August 11, 2021 00:41
@MelvinBot MelvinBot requested review from bondydaa and removed request for a team August 11, 2021 00:41
@timszot timszot requested review from a team and removed request for bondydaa August 11, 2021 00:41
@MelvinBot MelvinBot requested review from bondydaa and removed request for a team August 11, 2021 00:43
@timszot timszot removed the request for review from bondydaa August 11, 2021 00:43
@timszot
Copy link
Contributor Author

timszot commented Aug 11, 2021

Sorry Bondy for the pings, was trying to get pullerbear to pick someone else...

@timszot timszot changed the title [HOLD] Always auto name and create new workspaces from oldDot Always auto name and create new workspaces from oldDot Aug 11, 2021
@timszot
Copy link
Contributor Author

timszot commented Aug 11, 2021

Ok @TomatoToaster HOLD removed and ready for one more review before it can be merged.

bondydaa
bondydaa previously approved these changes Aug 11, 2021
Copy link
Contributor

@bondydaa bondydaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a couple of NAB otherwise looks good to my newbie-app-eyes

src/Expensify.js Outdated Show resolved Hide resolved
src/pages/ValidateLogin2FANewWorkspacePage.js Outdated Show resolved Hide resolved
src/pages/ValidateLoginNewWorkspacePage.js Outdated Show resolved Hide resolved
Copy link
Contributor

@bondydaa bondydaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@timszot
Copy link
Contributor Author

timszot commented Aug 11, 2021

Self merging since tests are passing and this is approved.

@timszot timszot merged commit 4ec7474 into main Aug 11, 2021
@timszot timszot deleted the timszot_autoCreateWorkspace branch August 11, 2021 17:18
@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @timszot in version: 1.0.83-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 cancelled 🔪
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @isagoico in version: 1.0.85-9 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants