Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HOLD] Revert "Update Onyx hash (LRU cache)" #4611

Closed
wants to merge 1 commit into from
Closed

[HOLD] Revert "Update Onyx hash (LRU cache)" #4611

wants to merge 1 commit into from

Conversation

iwiznia
Copy link
Contributor

@iwiznia iwiznia commented Aug 12, 2021

Reverts #4509

See #4595

@iwiznia iwiznia self-assigned this Aug 12, 2021
@iwiznia iwiznia requested a review from a team as a code owner August 12, 2021 17:24
@MelvinBot MelvinBot requested review from MariaHCD and removed request for a team August 12, 2021 17:25
@github-actions
Copy link
Contributor

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

@iwiznia iwiznia removed the request for review from MariaHCD August 12, 2021 17:32
@francoisl francoisl changed the title Revert "Update Onyx hash (LRU cache)" [HOLD] Revert "Update Onyx hash (LRU cache)" Aug 12, 2021
@francoisl
Copy link
Contributor

Holding on discussion in https://expensify.slack.com/archives/C01GTK53T8Q/p1628776131244300 to see if we can get a fix that doesn't involve reverting.

@francoisl
Copy link
Contributor

The alternative fix worked, closing this as it's no longer needed.

@francoisl francoisl closed this Aug 13, 2021
@francoisl francoisl deleted the revert-4509-kidroca/onyx-lru-cache branch August 13, 2021 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francoisl francoisl francoisl approved these changes

Assignees

@iwiznia iwiznia

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iwiznia @francoisl