Clear storage immediately on sign out

[kidroca]

cc @iwiznia @francoisl

Details

Waiting for set to complete gives enough time for other connections (triggered by authToken change) to be initiated with cached data
This causes a bug where the SignIn component does not have correct state
More details are available in the linked issue

Fixed Issues

$ #4595

Tests

1. Launch the mobile app
2. Switch a few chats
3. Log out

You should be on the initial Login screen, where you need to input your email

QA Steps

Same as above

Tested On

• Web
• Mobile Web
• Desktop
• iOS
• Android

Screenshots

Web

New.Expensify.-.Google.Chrome.2021-08-12.21-49-38.mp4

Mobile Web

Android.Emulator.-.Pixel_2_API_29_5554.2021-08-12.21-51-05.mp4

Desktop

iOS

Screen.Recording.2021-08-12.at.21.57.39.mov

Android

Android.Emulator.-.Pixel_2_API_29_5554.2021-08-12.21-07-17.mp4

[kidroca]

I'm testing the rest of the platforms (iOS still building...)

[github-actions]

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

[iwiznia]

Looks good. @francoisl please review and merge once testing has been done in all platforms. Then please let QA know they can retest in the issue 🙏

[kidroca]

Tested on all platform and added videos in the description.
This is ready for review.

[OSBotify]

🚀 Cherry-picked to staging by @francoisl in version: 1.0.85-2 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[botify]

This has been deployed to production and is now subject to a 7-day regression period.
If no regressions arise, payment will be issued on 2021-08-24. 🎊

[OSBotify]

🚀 Deployed to production by @isagoico in version: 1.0.85-9 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to staging by @francoisl in version: 1.0.85-10 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[botify]

This has been deployed to production and is now subject to a 7-day regression period.
If no regressions arise, payment will be issued on 2021-09-01. 🎊

[OSBotify]

🚀 Deployed to production by @roryabraham in version: 1.0.86-11 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

[botify]

This has been deployed to production and is now subject to a 7-day regression period.
If no regressions arise, payment will be issued on 2021-09-06. 🎊