-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NO QA]Update Billing-page-coming-soon.md #50118
base: main
Are you sure you want to change the base?
Conversation
Added page details related to billing and discounts coming from Expensify/Expensify#420340
@thesahindia Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
@hoangzinh @ One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
A preview of your ExpensifyHelp changes have been deployed to https://3bbd70fd.helpdot.pages.dev ⚡️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving to trigger the assignment.
🎯 @thesahindia, thanks for reviewing and testing this PR! 🎉 An E/App issue has been created to issue payment here: #50435. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docs/articles/new-expensify/billing-and-subscriptions/Billing-page-coming-soon.md
Outdated
Show resolved
Hide resolved
docs/articles/new-expensify/billing-and-subscriptions/Billing-page-coming-soon.md
Outdated
Show resolved
Hide resolved
- Whether you’re using the Expensify Visa® Commercial Card | ||
- Active members | ||
|
||
An active member is anyone who chats, creates, submits, approves, reimburses, or exports a report in Expensify in any given month. This includes Copilots and automated settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Automated settings", or is it more "automated actions" or "automation settings"?
Bump @slafortune |
1 similar comment
Bump @slafortune |
…page-coming-soon.md Co-authored-by: Carlos Alvarez <carlos@expensify.com>
I think I figured out the issue with the failing check and I submitted a PR to fix it #51806 |
Added page details related to billing and discounts coming from https://github.com/Expensify/Expensify/issues/420340
Details
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/420340
PROPOSAL:
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop