Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[No QA] Add accessibility check to each PR in the deployChecklist #5117

Merged
merged 44 commits into from
Oct 19, 2021
Merged

[No QA] Add accessibility check to each PR in the deployChecklist #5117

merged 44 commits into from
Oct 19, 2021

Commits on Sep 7, 2021

  1. create test with desired format

    @Julesssss
    Julesssss committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    dcfb429 View commit details
    Browse the repository at this point in the history

  2. implement new issue formatting, to match test

    @Julesssss
    Julesssss committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    821c371 View commit details
    Browse the repository at this point in the history

  3. update first 3 tests using the new formatting, replace example test

    @Julesssss
    Julesssss committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    90112c5 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2021

  1. modify new formatting of deploy blocker header

    @Julesssss
    Julesssss committed Sep 8, 2021
    Configuration menu
    Copy the full SHA
    e1fa3f5 View commit details
    Browse the repository at this point in the history

  2. resolve remaining tests, improve test formatting

    @Julesssss
    Julesssss committed Sep 8, 2021
    Configuration menu
    Copy the full SHA
    2833a20 View commit details
    Browse the repository at this point in the history

  3. attempt to preserve the accessibility status

    @Julesssss
    Julesssss committed Sep 8, 2021
    Configuration menu
    Copy the full SHA
    e6befa3 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2021

  1. Style

    @stitesExpensify
    stitesExpensify committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    c247f82 View commit details
    Browse the repository at this point in the history

  2. Style

    @stitesExpensify
    stitesExpensify committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    b5a6148 View commit details
    Browse the repository at this point in the history

  3. Style

    @stitesExpensify
    stitesExpensify committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    e2e835d View commit details
    Browse the repository at this point in the history

  4. more style: 

    :
    @stitesExpensify
    stitesExpensify committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    74a9fcd View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2021

  1. Update to have reusable snippets instead of hard coding the body

    @stitesExpensify
    stitesExpensify committed Oct 4, 2021
    Configuration menu
    Copy the full SHA
    cd9e8f0 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2021

  1. Update regex to find new format

    @stitesExpensify
    stitesExpensify committed Oct 5, 2021
    Configuration menu
    Copy the full SHA
    08d93d9 View commit details
    Browse the repository at this point in the history

  2. Update tests for new format

    @stitesExpensify
    stitesExpensify committed Oct 5, 2021
    Configuration menu
    Copy the full SHA
    ebbd613 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' of github.com:Expensify/App into jules-deployChec… 

    …klistAddAccessibleCheck
    @stitesExpensify
    stitesExpensify committed Oct 5, 2021
    Configuration menu
    Copy the full SHA
    c2d23ac View commit details
    Browse the repository at this point in the history

  4. Fix regex to properly capture new groups

    @stitesExpensify
    stitesExpensify committed Oct 5, 2021
    Configuration menu
    Copy the full SHA
    1a32a5a View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2021

  1. Merge branch 'main' of github.com:Expensify/App into jules-deployChec… 

    …klistAddAccessibleCheck
    @stitesExpensify
    stitesExpensify committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    0045660 View commit details
    Browse the repository at this point in the history

  2. Add more PRs to the list and chagne hard-coded list

    @stitesExpensify
    stitesExpensify committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    1dcb806 View commit details
    Browse the repository at this point in the history

  3. Fix capture grouping

    @stitesExpensify
    stitesExpensify committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    e09df24 View commit details
    Browse the repository at this point in the history

  4. Fix match

    @stitesExpensify
    stitesExpensify committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    f4ce0e6 View commit details
    Browse the repository at this point in the history

  5. Fix tests to check for the correct checkbox

    @stitesExpensify
    stitesExpensify committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    36139d9 View commit details
    Browse the repository at this point in the history

  6. Update test to fix version that I didn't properly convert

    @stitesExpensify
    stitesExpensify committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    d45c3e3 View commit details
    Browse the repository at this point in the history

  7. Update test to look for new format

    @stitesExpensify
    stitesExpensify committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    9e8d6be View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2021

  1. Merge branch 'main' of github.com:Expensify/App into jules-deployChec… 

    …klistAddAccessibleCheck
    @stitesExpensify
    stitesExpensify committed Oct 11, 2021
    Configuration menu
    Copy the full SHA
    0a05279 View commit details
    Browse the repository at this point in the history

  2. Update regex for deploy blockers

    @stitesExpensify
    stitesExpensify committed Oct 11, 2021
    Configuration menu
    Copy the full SHA
    37aa160 View commit details
    Browse the repository at this point in the history

  3. Update tests for proper format

    @stitesExpensify
    stitesExpensify committed Oct 11, 2021
    Configuration menu
    Copy the full SHA
    5b4ebe0 View commit details
    Browse the repository at this point in the history

  4. Update param order

    @stitesExpensify
    stitesExpensify committed Oct 11, 2021
    Configuration menu
    Copy the full SHA
    9819985 View commit details
    Browse the repository at this point in the history

  5. style

    @stitesExpensify
    stitesExpensify committed Oct 11, 2021
    Configuration menu
    Copy the full SHA
    438f5d9 View commit details
    Browse the repository at this point in the history

  6. Fix duplicated PR in list

    @stitesExpensify
    stitesExpensify committed Oct 11, 2021
    Configuration menu
    Copy the full SHA
    232dfdc View commit details
    Browse the repository at this point in the history

  7. Also make sure accessibility issues get checked off

    @stitesExpensify
    stitesExpensify committed Oct 11, 2021
    Configuration menu
    Copy the full SHA
    b03a026 View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2021

  1. Update regex again for the possibility of different spacing

    @stitesExpensify
    stitesExpensify committed Oct 12, 2021
    Configuration menu
    Copy the full SHA
    52676ec View commit details
    Browse the repository at this point in the history

  2. Update tests to match the ones we had originally

    @stitesExpensify
    stitesExpensify committed Oct 12, 2021
    Configuration menu
    Copy the full SHA
    32db6a0 View commit details
    Browse the repository at this point in the history

  3. Swap everything back to issues like it was in the original tests

    @stitesExpensify
    stitesExpensify committed Oct 12, 2021
    Configuration menu
    Copy the full SHA
    eeb0c1d View commit details
    Browse the repository at this point in the history

  4. Update compiled actions build

    @stitesExpensify
    stitesExpensify committed Oct 12, 2021
    Configuration menu
    Copy the full SHA
    84ebbe4 View commit details
    Browse the repository at this point in the history

  5. Remove the - before the PR name

    @stitesExpensify
    stitesExpensify committed Oct 12, 2021
    Configuration menu
    Copy the full SHA
    6e47e40 View commit details
    Browse the repository at this point in the history

  6. Remove listStart

    @stitesExpensify
    stitesExpensify committed Oct 12, 2021
    Configuration menu
    Copy the full SHA
    8176df1 View commit details
    Browse the repository at this point in the history

  7. Remove - to fix tests

    @stitesExpensify
    stitesExpensify committed Oct 12, 2021
    Configuration menu
    Copy the full SHA
    1e10a0e View commit details
    Browse the repository at this point in the history

  8. Update compiled build actions

    @stitesExpensify
    stitesExpensify committed Oct 12, 2021
    Configuration menu
    Copy the full SHA
    1db0b22 View commit details
    Browse the repository at this point in the history

  9. Change accessabilityPRList to accessablePRList

    @stitesExpensify
    stitesExpensify committed Oct 12, 2021
    Configuration menu
    Copy the full SHA
    e267340 View commit details
    Browse the repository at this point in the history

  10. Remove accessilibty from deploy blocker list

    @stitesExpensify
    stitesExpensify committed Oct 12, 2021
    Configuration menu
    Copy the full SHA
    2abbea9 View commit details
    Browse the repository at this point in the history

  11. Update regex to de-duplicate logic

    @stitesExpensify
    stitesExpensify committed Oct 12, 2021
    Configuration menu
    Copy the full SHA
    bfe3eca View commit details
    Browse the repository at this point in the history

  12. Should be 2 spaces, not 8

    @stitesExpensify
    stitesExpensify committed Oct 12, 2021
    Configuration menu
    Copy the full SHA
    d7fea21 View commit details
    Browse the repository at this point in the history

  13. Add duplicate back

    @stitesExpensify
    stitesExpensify committed Oct 12, 2021
    Configuration menu
    Copy the full SHA
    fc8c27a View commit details
    Browse the repository at this point in the history

  14. re-add initial - for issue

    @stitesExpensify
    stitesExpensify committed Oct 12, 2021
    Configuration menu
    Copy the full SHA
    983de3b View commit details
    Browse the repository at this point in the history

  15. Update actions build

    @stitesExpensify
    stitesExpensify committed Oct 12, 2021
    Configuration menu
    Copy the full SHA
    b78918e View commit details
    Browse the repository at this point in the history