[No QA] Add accessibility check to each PR in the deployChecklist

[Julesssss]

CC: @roryabraham

Details

We are adding accessibility to newDot! Because of that we need to update our deploy checklists to accommodate for both QA and accessibility testing.

Accessibility failures will not prevent deploys as of now because nobody is writing accessible code. In the future we will be including accessibility checkboxes as a deploy blocker.

Old Format:

• Update Get started button to Finish setup when a user has draft data saved in the VBA flow #5258
• [NoQA] Update "Troubleshooting" docs #5262

New Format:

• Update Get started button to Finish setup when a user has draft data saved in the VBA flow #5258

  • QA
  • Accessibility

• [NoQA] Update "Troubleshooting" docs #5262

  • QA
  • Accessibility

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/175521

Tests

SO MANY automated tests, and that's about the best we can do unfortunately. This can't be tested locally.

QA Steps

1. Make sure the checklist is created in the new format defined above
2. Make sure that when we add deploy blocker labels, it is added to the deploy checklist just like it currently does
3. Make sure that when we CP to staging, they are added to the checklist

Tested On

n/a

Screenshots

n/a

[stitesExpensify]

Un-JK, the fixes were easier than I was expecting (thank god)

[roryabraham]

Thanks for including lots of unit test updates. It's really important to give us more confidence about the live-testing. Another thing that might be useful is to just print the result of the generateStagingDeployCashBody and paste it into a GitHub comment to get an idea what it looks like all rendered out. Only blocker is removing the accessibility stuff from the deploy blocker section.

[stitesExpensify]

Here's the example checklist from createOrUpdateStagingDeploy #5782

[roryabraham]

Can we please add a - before each PR in the checklist? That way, GH will expand the PR title like this:

I think that will help reduce the cognitive load for Applause and deployers reviewing the checklist / make it easy to quickly check off any [No QA] PRs.

[stitesExpensify]

WTF I literally just removed that, that was the "thing I have to fix" because it wouldn't work in my test on this PR's description. I will add it back. 6e47e40

[stitesExpensify]

Updated, and updated the demo issue for the new format #5782

[Julesssss]

Looks good, but I'm not going to officially review as I contributed with the early commits.

[stitesExpensify]

Holding this until we're sure applause is ready to start

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging by @stitesExpensify in version: 1.1.8-10 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production by @roryabraham in version: 1.1.10-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅