-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NoQA] Update "Troubleshooting" docs #5262
Conversation
Describe some environment variables and specifically the USE_WEB_PROXY as it's causes issues for external contributors
b201f9a
to
7708048
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it!
Updated, @AndrewGable should I remove the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great update! What do you think to create some @here
post in #expensify-open-source
as a questionnaire/survey to ask about the starting flow, what is confusing/what could be improved to start the App locally and start working.
Now we are busy, but it could be nice to explicitly ask for feedback instead of relying on people to show up. I think often people are afraid to say when they struggle with something/are confused, because they do not see other people ask about it and assume it is their mistake. @Beamanator @AndrewGable ? 👀
@mountiny that definitely sounds valuable to me, even @mateomorris posted in the Slack thread about some difficulties he had running the iOS app, so we'd probably get even more useful feedback by pinging everyone in Slack. Maybe we don't need to ping |
Asking sounds good, but I usually do not think people are afraid to ask if they are trying to get paid ASAP. |
Co-authored-by: Andrew Gable <andrewgable@gmail.com>
Sorry @AndrewGable I've forgotten about this PR, just applied your suggested changes |
@AndrewGable I see your point there, at the same time, there could be many junior developers trying to learn while also getting paid and I think that for those, it might be bigger barrier to step up and ask as they might feel it is a dumb question. Especially students, who might see this project as a great way to make some money while studying are example of someone who might not be confident enough in their skills yet so they could be hesitant to ask questions. Asking for suggestions and feedback directly (I would even use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just couple minor styling suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great improvement, thank you! @mountiny feel free to merge once you are happy with it. Also feel free to post anything in Slack, the more conversation and discussion about how to improve the set up, the better 😸
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great improvement!
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to production by @chiragsalian in version: 1.1.4-0 🚀
|
Details
Describe some environment variables and specifically the USE_WEB_PROXY
as it causes issues for external contributors see slack thread🧵
Fixed Issues
N/A (Docs update)
Tests
N/A (Docs update)
QA Steps
N/A (Docs update)
Tested On
N/A (Docs update)
cc @Beamanator