Update Get started button to Finish setup when a user has draft data saved in the VBA flow
#5258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luacmartins
changed the title
Get started button to Finish setup as soon as a user's information have been saved for a step in VBA flowGet started button to Finish setup when a user has draft data saved in the VBA flow
AndrewGable
changed the title
Get started button to Finish setup when a user has draft data saved in the VBA flowGet started button to Finish setup when a user has draft data saved in the VBA flow
|
Placing on hold, can you ping me when it's ready for merge and review? Thanks! |
luacmartins
changed the title
Get started button to Finish setup when a user has draft data saved in the VBA flowGet started button to Finish setup when a user has draft data saved in the VBA flow
|
No longer on hold! @AndrewGable all yours for review! |
AndrewGable
approved these changes
Sep 28, 2021
|
Looking real good! I couldn't find anything to comment on 😄 |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
15 tasks
|
🚀 Deployed to staging by @AndrewGable in version: 1.1.3-2 🚀
|
|
@luacmartins Hello! I think we're blocked from testing this. When creating an account with gmail it asks us to add a new domain with a work email. I think this might need to be internal QA. |
|
@isagoico I updated the testing instructions. Could you please try again? |
|
🚀 Deployed to production by @chiragsalian in version: 1.1.4-0 🚀
|
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
The button in the Workspace card page should change to Finish setup when a user has entered data into the form and closes the modal.
Fixed Issues
$ #4892
Tests
Settings > Select Workspace > Get Started.Finish setup.QA Steps
Steps above.
Tested On
Screenshots
Web
web.mov
Mobile Web
Desktop
desktop.mov
iOS
Android