Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compare against null because sequenceNumber can be 0 #6275

Merged
merged 4 commits into from
Nov 19, 2021
Merged

Compare against null because sequenceNumber can be 0 #6275

merged 4 commits into from
Nov 19, 2021

Conversation

chiragsalian
Copy link
Contributor

Details

Fixed Issues

$ #6233

Tests / QA steps

  1. Open app and login
  2. Create a new chat by going + > New Chat and start chat with a user never had a conversation before
  3. Type and send a single message
  4. Long tap on it, mark as unread
  5. Go back to LNH. Confirm its message preview is bolded to indicate its unread (unlike the issue video).

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

@chiragsalian chiragsalian self-assigned this Nov 10, 2021
@chiragsalian chiragsalian requested a review from a team as a code owner November 10, 2021 16:12
@chiragsalian chiragsalian changed the title Compare against null because sequenceNumber can be 0 [HOLD] Compare against null because sequenceNumber can be 0 Nov 10, 2021
@MelvinBot MelvinBot requested review from cead22 and removed request for a team November 10, 2021 16:13
@chiragsalian
Copy link
Contributor Author

chiragsalian commented Nov 10, 2021 •
edited
Loading

On HOLD since we're on a merge freeze this week.

@chiragsalian chiragsalian changed the title [HOLD] Compare against null because sequenceNumber can be 0 Compare against null because sequenceNumber can be 0 Nov 16, 2021
@chiragsalian
Copy link
Contributor Author

Off HOLD and ready for review.

cead22
cead22 requested changes Nov 19, 2021
View reviewed changes
src/libs/actions/Report.js Outdated Show resolved Hide resolved
@chiragsalian
Copy link
Contributor Author

Updated.

@chiragsalian chiragsalian merged commit cba4286 into main Nov 19, 2021
@chiragsalian chiragsalian deleted the chirag-logic-fix branch November 19, 2021 22:01
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Nov 22, 2021
Closed
@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @chiragsalian in version: 1.1.15-18 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.16-10 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cead22 cead22 cead22 approved these changes

Assignees

@chiragsalian chiragsalian

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chiragsalian @OSBotify @cead22