Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compare against null because sequenceNumber can be 0 #6275

Merged
merged 4 commits into from
Nov 19, 2021
Merged

Compare against null because sequenceNumber can be 0 #6275

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
73e57f6
Compare against null because sequenceNumber can be 0
chiragsalian Nov 10, 2021
752d728
Merge branch 'main' into chirag-logic-fix
chiragsalian Nov 19, 2021
9d1b4bc
small improvement
chiragsalian Nov 19, 2021
5d89800
comment update
chiragsalian Nov 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/libs/actions/Report.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1197,7 +1197,9 @@ function updateLastReadActionID(reportID, sequenceNumber) {

// Need to subtract 1 from sequenceNumber so that the "New" marker appears in the right spot (the last read
// action). If 1 isn't subtracted then the "New" marker appears one row below the action (the first unread action)
const lastReadSequenceNumber = (sequenceNumber - 1) || reportMaxSequenceNumbers[reportID];
// Note: sequenceNumber can be 1 for the first message, so we can't use
// (sequenceNumber - 1) || reportMaxSequenceNumbers[reportID] because the first expression results in 0 which is falsy.
const lastReadSequenceNumber = _.isNumber(sequenceNumber) ? (sequenceNumber - 1) : reportMaxSequenceNumbers[reportID];

// We call this method in many cases where there's nothing to update because we already updated it, so we avoid
// doing an unnecessary server call if the last read is the same one we had already
Expand Down