Fix : Pressing Tab button in AddressSearch inputs

[developvsn]

Details

Fixed Issues

$ 6235

Tests | QA Steps

1.Navigate to Company Information window.
2.Type an address that yield results in address search input.
3.Press "Tab" key or click to other input.

Tested On

• Web
• Mobile Web
• Desktop
• iOS
• Android

Screenshots

Web

web.mov

Desktop

desktop.mov

iOS

Android

Mobile Web

[developvsn]

I have read the CLA Document and I hereby sign the CLA

[github-actions]

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

[NikkiWines]

Needs some minor adjustments, mainly stylistic.

[NikkiWines]

hmm, I don't think this needs to be it's own variable. Why not do the following?

onKeyPress: (event) => {
    if (event.key !== 'Tab' || isSelected) {
        return;
    }
    googlePlacesRef.current.setAddressText('');
},

[developvsn]

We tried similar way, but with "&&" operator instead "||", which led to the fact that only the last entered character would fit in the text field. Thank you.

[NikkiWines]

👍

[OSBotify]

@developvsn, Great job getting your first Expensify/App pull request over the finish line! 🎉

I know there's a lot of information in our contributing guidelines, so here are some points to take note of 📝:

1. Now that your first PR has been merged, you can be hired for another issue. Once you've completed a few issues, you may be eligible to work on more than one job at a time.
2. Once your PR is deployed to our staging servers, it will undergo quality assurance (QA) testing. If we find that it doesn't work as expected or causes a regression, you'll be responsible for fixing it. Typically, we would revert this PR and give you another chance to create a similar PR without causing a regression.
3. Once your PR is deployed to production, we start a 7-day timer ⏰. After it has been on production for 7 days without causing any regressions, then we pay out the Upwork job. 💰

So it might take a while before you're paid for your work, but we typically post multiple new jobs every day, so there's plenty of opportunity. I hope you've had a positive experience contributing to this repo! 😊

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[parasharrajat]

@NikkiWines These commits are not signed.

[NikkiWines]

Nice catch @parasharrajat, I completely missed that (I've become too reliant on our automated checks in other repos 😅)

Let's wait on consensus from Cole in this Slack thread, but I think Brandon's suggestion to revert + re-merge with signed commits is a good idea.

[OSBotify]

🚀 Deployed to staging by @NikkiWines in version: 1.1.15-18 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[developvsn]

Nice catch @parasharrajat, I completely missed that (I've become too reliant on our automated checks in other repos 😅)

Let's wait on consensus from Cole in this Slack thread, but I think Brandon's suggestion to revert + re-merge with signed commits is a good idea.

Nikki can you help with slack, I think we might lose some up-to-date information. We sent an invite request to contributors' email a month ago already.

[NikkiWines]

Ah, if you haven't been invited yet can you resend the email? It may have somehow gotten lost, someone on our contributor-management team will add you to slack.

Going to push up a revert of this and then revert the revert so that the same changes are implemented but the commits are signed.

[OSBotify]

🚀 Deployed to production by @roryabraham in version: 1.1.16-10 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅