Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix : Pressing Tab button in AddressSearch inputs #6345

Merged
merged 5 commits into from
Nov 19, 2021
Merged

Fix : Pressing Tab button in AddressSearch inputs #6345

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
68de973
Fix pressing Tab button in AddressSearch inputs
developvsn Nov 17, 2021
1223001
Correct code style
developvsn Nov 18, 2021
0cf5247
Remove extra line
developvsn Nov 18, 2021
3676172
Code styling
developvsn Nov 19, 2021
7cc6588
Code styling
developvsn Nov 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions src/components/AddressSearch.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ const defaultProps = {
const AddressSearch = (props) => {
const googlePlacesRef = useRef();
const [displayListViewBorder, setDisplayListViewBorder] = useState(false);
const [isSelected, setIsSelected] = useState(true);
useEffect(() => {
if (!googlePlacesRef.current) {
return;
Expand Down Expand Up @@ -82,14 +83,30 @@ const AddressSearch = (props) => {
}
};

const checkPressingTab = (event) => {
if (event.key !== 'Tab') {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, I don't think this needs to be it's own variable. Why not do the following?

onKeyPress: (event) => {
    if (event.key !== 'Tab' || isSelected) {
        return;
    }
    googlePlacesRef.current.setAddressText('');
},

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We tried similar way, but with "&&" operator instead "||", which led to the fact that only the last entered character would fit in the text field. Thank you.

return;
}
if (isSelected) {
return;
}
googlePlacesRef.current.setAddressText('');
};
return (
<GooglePlacesAutocomplete
ref={googlePlacesRef}
fetchDetails
onBlur={() => {
if (isSelected) {
NikkiWines marked this conversation as resolved.
Show resolved Hide resolved
return;
}
googlePlacesRef.current.setAddressText('');
}}
suppressDefaultStyles
enablePoweredByContainer={false}
onPress={(data, details) => {
saveLocationDetails(details);
setIsSelected(true);

// After we select an option, we set displayListViewBorder to false to prevent UI flickering
setDisplayListViewBorder(false);
Expand All @@ -109,8 +126,12 @@ const AddressSearch = (props) => {
label: props.label,
containerStyles: props.containerStyles,
errorText: props.errorText,
onKeyPress: (event) => {
checkPressingTab(event);
},
onChangeText: (text) => {
const isTextValid = !_.isEmpty(text) && _.isEqual(text, props.value);
setIsSelected(false);

// Ensure whether an address is selected already or has address value initialized.
if (!_.isEmpty(googlePlacesRef.current.getAddressText()) && !isTextValid) {
Expand Down