Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

force recalculation of drawer on orientation change #6356

Merged
merged 1 commit into from
Nov 18, 2021

Conversation

parasharrajat
Copy link
Member

@parasharrajat parasharrajat commented Nov 17, 2021

Details

Fixed Issues

$ #5591

Tests | QA Steps

  1. On an Android with a big screen
  2. Open the app
  3. On LHN, change the orientation to landscape

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web | Desktop

output_file.mp4

Mobile Web

iOS

Android

Screenrecorder-2021-11-18-02-47-41-362.mp4

@parasharrajat parasharrajat requested a review from a team as a code owner November 17, 2021 21:27
@MelvinBot MelvinBot requested review from Julesssss and removed request for a team November 17, 2021 21:27
@parasharrajat parasharrajat mentioned this pull request Nov 18, 2021
5 tasks
Copy link
Contributor

@Julesssss Julesssss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests well on iOS/Android 👍

@Julesssss Julesssss merged commit a520c44 into Expensify:main Nov 18, 2021
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @Julesssss in version: 1.1.15-18 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@mvtglobally
Copy link

@parasharrajat @Julesssss Do you need this QAed on Android app only or all platforms?

@parasharrajat
Copy link
Member Author

All.. @mvtglobally

@Julesssss
Copy link
Contributor

Yep, all please.

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.16-10 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants