fix(8840): fixed modal state on resize #9180

allroundexperts · 2022-05-26T14:22:39Z

Details

Fixed Issues

$ #8840

Tests

Open any chat room.
Upload an image so that preview modal appears.
Resize the window to small screen.
Verify if the modal doesn't disappear.
Change the screen back to the original size.
The modal should still remain visible.

Verify that no errors appear in the JS console

PR Review Checklist

Contributor (PR Author) Checklist

PR Reviewer Checklist

QA Steps

Open any chat room.
Upload an image so that preview modal appears.
Resize the window to small screen.
Verify if the modal doesn't disappear.
Change the screen back to the original size.
The modal should still remain visible.

Verify that no errors appear in the JS console

Screenshots

Web

169618789-cef14464-f518-4730-921f-9efcf6776372.mov

Mobile Web

screen-recording-2022-05-26-at-85625-pm_JcCKT0R7.mp4

Desktop

screen-recording-2022-05-26-at-85243-pm_rNUV8rmm.mp4

iOS

Screen.Recording.2022-05-26.at.8.11.45.PM.mov

Android

Screen.Recording.2022-05-26.at.8.15.22.PM.mov

luacmartins

LGTM and tests well! Thanks for the fix @allroundexperts!

We could probably have updated @react-navigation/drawer to the latest 6.4.1 version, but maybe we can do that in a separate PR and bump all of them.

luacmartins · 2022-05-27T16:13:48Z

@rushatgabhane all yours!

rushatgabhane · 2022-05-27T22:17:54Z

@allroundexperts bug: LHN (Left Hand Navigator) is blank on resizing from small to large window.
Did v6.3 break it? I don't remember seeing it in v6.2

Screen.Recording.2022-05-28.at.1.08.46.AM.mov

luacmartins · 2022-05-27T22:19:31Z

@rushatgabhane Interesting. I did not experience that in my tests, but I'll try again on Monday.

allroundexperts · 2022-05-30T18:30:34Z

@allroundexperts bug: LHN (Left Hand Navigator) is blank on resizing from small to large window. Did v6.3 break it? I don't remember seeing it in v6.2

Screen.Recording.2022-05-28.at.1.08.46.AM.mov

@rushatgabhane Did you run npm install? I can't seem to reproduce this.

rushatgabhane · 2022-05-30T18:40:44Z

Did you run npm install

@allroundexperts I hadn't thanks for the help. The bug is no longer reproducible

You might have posted the wrong video for web in PR description because it shows that the LHN bug still exists. Please ping me after that's updated

rushatgabhane

@luacmartins LGTM! 🎉

Here's updated video for web

Screen.Recording.2022-06-01.at.6.10.37.PM.mov

#### PR Reviewer Checklist

I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- iOS / native
- Android / native
- iOS / Safari
- Android / Chrome
- MacOS / Chrome
- MacOS / Desktop
I verified there are no console errors (if there’s a console error not related to the PR, report it or open an issue for it to be fixed)
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained “why” the code was doing something instead of only explaining “what” the code was doing.
- I verified any copy / text shown in the product was added in all src/languages/* files
- I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named “index.js”. All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- Any functional components have the displayName property
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn’t already exist
- The style can’t be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.

OSBotify · 2022-06-01T19:49:28Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2022-06-06T18:29:56Z

🚀 Deployed to staging by @luacmartins in version: 1.1.72-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2022-06-08T16:30:54Z

🚀 Deployed to production by @yuwenmemon in version: 1.1.73-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

marcaaron · 2022-09-29T02:24:40Z

src/libs/Navigation/AppNavigator/BaseDrawerNavigator.js

@@ -53,7 +53,7 @@ class BaseDrawerNavigator extends Component {
        const content = (
            <Drawer.Navigator
                backBehavior="none"
-                key={`BaseDrawerNavigator${this.props.isSmallScreenWidth}`}
+                key="BaseDrawerNavigator"


Why does this need a key ? 🤔

lol good point

I mean I assume there is some reason. but Not sure why and less sure why it was changed...

I think the idea is that the key would cause react to remount the drawer navigator if the isSmallScreenWidth prop changes (unclear why), but the key is hardcoded now so I think it's pointless?

It was introduced here to force the navigator to unmount and fit orientation changes in mobile devices. We then removed it since that bug was apparently fixed in a later version of react-navigation as described here. This key is now useless and we should have just removed it altogether haha

fix(8840): fixed modal state on resize

72222ca

allroundexperts marked this pull request as ready for review May 26, 2022 16:25

allroundexperts requested a review from a team as a code owner May 26, 2022 16:25

melvin-bot bot requested review from luacmartins and rushatgabhane and removed request for a team, luacmartins and rushatgabhane May 26, 2022 16:25

allroundexperts mentioned this pull request May 26, 2022

[HOLD for payment 2022-06-15] [$500] Web - Attachments - Attaching a picture disappears when minimizing a window #8840

Closed

fix: updated to 6.3.0

381de2b

luacmartins approved these changes May 27, 2022

View reviewed changes

rushatgabhane approved these changes Jun 1, 2022

View reviewed changes

luacmartins merged commit 3493f3c into Expensify:main Jun 1, 2022

yuwenmemon mentioned this pull request Jun 6, 2022

Deploy Checklist: New Expensify 2022-06-06 #9326

Closed

47 tasks

marcaaron reviewed Sep 29, 2022

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(8840): fixed modal state on resize #9180

fix(8840): fixed modal state on resize #9180

allroundexperts commented May 26, 2022 •

edited

Loading

luacmartins left a comment

luacmartins commented May 27, 2022

rushatgabhane commented May 27, 2022

luacmartins commented May 27, 2022

allroundexperts commented May 30, 2022

rushatgabhane commented May 30, 2022 •

edited

Loading

rushatgabhane left a comment •

edited

Loading

OSBotify commented Jun 1, 2022

OSBotify commented Jun 6, 2022

OSBotify commented Jun 8, 2022

marcaaron Sep 29, 2022

luacmartins Sep 29, 2022

marcaaron Sep 29, 2022

luacmartins Sep 29, 2022

fix(8840): fixed modal state on resize #9180

fix(8840): fixed modal state on resize #9180

Conversation

allroundexperts commented May 26, 2022 • edited Loading

Details

Fixed Issues

Tests

PR Review Checklist

Contributor (PR Author) Checklist

PR Reviewer Checklist

QA Steps

Screenshots

Web

Mobile Web

Desktop

iOS

Android

luacmartins left a comment

Choose a reason for hiding this comment

luacmartins commented May 27, 2022

rushatgabhane commented May 27, 2022

luacmartins commented May 27, 2022

allroundexperts commented May 30, 2022

rushatgabhane commented May 30, 2022 • edited Loading

rushatgabhane left a comment • edited Loading

Choose a reason for hiding this comment

#### PR Reviewer Checklist

OSBotify commented Jun 1, 2022

OSBotify commented Jun 6, 2022

OSBotify commented Jun 8, 2022

marcaaron Sep 29, 2022

Choose a reason for hiding this comment

luacmartins Sep 29, 2022

Choose a reason for hiding this comment

marcaaron Sep 29, 2022

Choose a reason for hiding this comment

luacmartins Sep 29, 2022

Choose a reason for hiding this comment

allroundexperts commented May 26, 2022 •

edited

Loading

rushatgabhane commented May 30, 2022 •

edited

Loading

rushatgabhane left a comment •

edited

Loading