Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NO QA]Sign commits for @OSBotify #6368

Merged
merged 2 commits into from
Nov 19, 2021
Merged

[NO QA]Sign commits for @OSBotify #6368

merged 2 commits into from
Nov 19, 2021

Conversation

AndrewGable
Copy link
Contributor

@AndrewGable AndrewGable commented Nov 19, 2021 •
edited
Loading

Details

Signs commits for @OSBotify when it creates a new version

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/149007

Tests

  1. CP this PR and verify the version commit is signed correctly

@AndrewGable AndrewGable self-assigned this Nov 19, 2021
@AndrewGable AndrewGable requested a review from a team as a code owner November 19, 2021 18:48
@github-actions
Copy link
Contributor

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

@MelvinBot MelvinBot requested review from stitesExpensify and removed request for a team November 19, 2021 18:49
stitesExpensify
stitesExpensify approved these changes Nov 19, 2021
View reviewed changes
Copy link
Contributor

@stitesExpensify stitesExpensify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jag96 Jag96 self-requested a review November 19, 2021 20:19
@Jag96 Jag96 merged commit bc538f5 into main Nov 19, 2021
@Jag96 Jag96 deleted the andrew-sign branch November 19, 2021 20:29
@AndrewGable AndrewGable mentioned this pull request Nov 19, 2021
Merged
@AndrewGable AndrewGable changed the title Sign commits for @OSBotify [NO QA]Sign commits for @OSBotify Nov 19, 2021
@AndrewGable
Copy link
Contributor Author

This is working now, still some other bugs to sort out, but it's getting closer.

Screen Shot 2021-11-19 at 3 03 20 PM

@stitesExpensify
Copy link
Contributor

Does that mean we can take this off hold? https://github.com/Expensify/Expensify/issues/185608

@AndrewGable
Copy link
Contributor Author

Not quite- I will let you know when.

@AndrewGable AndrewGable mentioned this pull request Nov 22, 2021
Merged
@OSBotify OSBotify mentioned this pull request Nov 22, 2021
Closed
@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @Jag96 in version: 1.1.15-18 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.16-10 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@AndrewGable AndrewGable mentioned this pull request Dec 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jag96 Jag96 Jag96 approved these changes

@stitesExpensify stitesExpensify stitesExpensify approved these changes

@roryabraham roryabraham Awaiting requested review from roryabraham

Assignees

@AndrewGable AndrewGable

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AndrewGable @stitesExpensify @OSBotify @Jag96