-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NO QA]Sign commits for @OSBotify #6629
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, are we just going to wait and see if manual CP's are broken when we require GPG-signed commits, and then address that when it comes up?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! We should address Rory's comment though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AndrewGable I think this looks good but we are very close to a prod deploy here today and I want to get that out before we merge this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Following the post-merge workflows with the checklist unlocked (normal staging deploy):
|
🥳 |
🚀 Deployed to staging by @roryabraham in version: 1.1.18-5 🚀
|
🚀 Deployed to production by @Julesssss in version: 1.1.21-1 🚀
|
Details
Second try at signing @OSBotify's commit's for creating new versions and cherry picks. This code was copied from these five reverted PRs:
1. #6379
2. #6377
3. #6374
4. #6371
5. #6368
Fixed Issues
Related https://github.com/Expensify/Expensify/issues/149007 (Doesn't fix 100% yet)
Tests