Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NO QA]Update one more instance of GITHUB_TOKEN to use OS_BOTIFY_TOKEN #6379

Merged
merged 1 commit into from
Nov 20, 2021

Conversation

AndrewGable
Copy link
Contributor

Details

We ran into one more issue using the GITHUB_TOKEN for Cherry Picking a workflow file, this should give us the required permissions to push that file.

Screen Shot 2021-11-19 at 5 08 47 PM

Fixed Issues

Fixed error above, related to https://github.com/Expensify/Expensify/issues/149007

Tests

  1. Merge and then CP this PR

@AndrewGable AndrewGable requested a review from Jag96 November 20, 2021 00:09
@AndrewGable AndrewGable requested a review from a team as a code owner November 20, 2021 00:09
@AndrewGable AndrewGable changed the title Update one more instance of GITHUB_TOKEN to use OS_BOTIFY_TOKEN [NO QA]Update one more instance of GITHUB_TOKEN to use OS_BOTIFY_TOKEN Nov 20, 2021
@MelvinBot MelvinBot requested review from aldo-expensify and removed request for a team November 20, 2021 00:09
@Jag96
Copy link
Contributor

Jag96 commented Nov 20, 2021

Skipping unnecessary e2e to fix GH actions

@Jag96 Jag96 merged commit 7bbbbf4 into main Nov 20, 2021
@Jag96 Jag96 deleted the andrew-checkout-bot branch November 20, 2021 00:15
@botify
Copy link

botify commented Nov 20, 2021

@Jag96 looks like this was merged without passing tests. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@Jag96 Jag96 removed the Emergency label Nov 20, 2021
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @Jag96 in version: 1.1.15-18 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.16-10 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants