Fix Download links #7132
Merged
Fix Download links #7132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parasharrajat
commented
Jan 11, 2022
| @@ -1,5 +1,8 @@ | |||
| import lodashGet from 'lodash/get'; | |||
| import Config from 'react-native-config'; | |||
There was a problem hiding this comment.
Can't import the Config from ./CONFIG directly, Its undefined may be due to circular dependency.
There was a problem hiding this comment.
I tried resolving it via creating another APP_URL file but still that was returning undefined.
tgolen
approved these changes
Jan 12, 2022
|
Those constant names are getting confusing now. We might want to go back at some point and clean them up. Specifically the difference between |
54 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Fixed Issues
$ #7123
Tests | QA Steps
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android
I feel screenshots are not needed.