Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Download links #7132

Merged
merged 2 commits into from
Jan 12, 2022
Merged

Fix Download links #7132

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4332931
Fix Download links
parasharrajat Jan 11, 2022
0e435b5
rename
parasharrajat Jan 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/CONST.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
import lodashGet from 'lodash/get';
import Config from 'react-native-config';
Copy link
Member Author

@parasharrajat parasharrajat Jan 11, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't import the Config from ./CONFIG directly, Its undefined may be due to circular dependency.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried resolving it via creating another APP_URL file but still that was returning undefined.


const CLOUDFRONT_URL = 'https://d2k5nsl2zxldvw.cloudfront.net';
const NEW_EXPENSIFY_URL = 'https://new.expensify.com';
const ACTIVE_ENVIRONMENT_NEW_EXPENSIFY_URL = lodashGet(Config, 'EXPENSIFY_URL_CASH', 'https://new.expensify.com');
const PLATFORM_OS_MACOS = 'Mac OS';
const ANDROID_PACKAGE_NAME = 'com.expensify.chat';

Expand All @@ -13,7 +16,7 @@ const CONST = {
APP_DOWNLOAD_LINKS: {
ANDROID: `https://play.google.com/store/apps/details?id=${ANDROID_PACKAGE_NAME}`,
IOS: 'https://apps.apple.com/us/app/expensify-cash/id1530278510',
DESKTOP: `${NEW_EXPENSIFY_URL}/NewExpensify.dmg`,
DESKTOP: `${ACTIVE_ENVIRONMENT_NEW_EXPENSIFY_URL}/NewExpensify.dmg`,
},
DATE: {
MOMENT_FORMAT_STRING: 'YYYY-MM-DD',
Expand Down Expand Up @@ -194,7 +197,7 @@ const CONST = {
CFPB_PREPAID_URL: 'https://cfpb.gov/prepaid',
STAGING_SECURE_URL: 'https://staging-secure.expensify.com/',
NEWDOT: 'new.expensify.com',
NEW_EXPENSIFY_URL,
NEW_EXPENSIFY_URL: 'https://new.expensify.com',
STAGING_NEW_EXPENSIFY_URL: 'https://staging.new.expensify.com',
OPTION_TYPE: {
REPORT: 'report',
Expand Down