[No QA] Upgrade eslint-config-expensify to enable no-multiple-empty-lines rule

.github/actions/awaitStagingDeploys/index.js

@@ -180,7 +180,6 @@ class GithubUtils {
         return this.octokitInternal;
     }
 
-
     /**
      * Finds one open `StagingDeployCash` issue via GitHub octokit library.
      *

.github/actions/bumpVersion/index.js

@@ -137,7 +137,6 @@ exports.generateAndroidVersionCode = function generateAndroidVersionCode(npmVers
     );
 };
 
-
 /**
  * Update the Android app versionName and versionCode.
  *

.github/actions/checkBundleVersionStringMatch/index.js

@@ -88,7 +88,6 @@ exports.generateAndroidVersionCode = function generateAndroidVersionCode(npmVers
     );
 };
 
-
 /**
  * Update the Android app versionName and versionCode.
  *

.github/actions/checkDeployBlockers/index.js

@@ -150,7 +150,6 @@ class GithubUtils {
         return this.octokitInternal;
     }
 
-
     /**
      * Finds one open `StagingDeployCash` issue via GitHub octokit library.
      *

.github/actions/createOrUpdateStagingDeploy/index.js

@@ -340,7 +340,6 @@ class GithubUtils {
         return this.octokitInternal;
     }
 
-
     /**
      * Finds one open `StagingDeployCash` issue via GitHub octokit library.
      *

.github/actions/getPullRequestDetails/index.js

@@ -221,7 +221,6 @@ class GithubUtils {
         return this.octokitInternal;
     }
 
-
     /**
      * Finds one open `StagingDeployCash` issue via GitHub octokit library.
      *

.github/actions/getReleaseBody/index.js

@@ -139,7 +139,6 @@ class GithubUtils {
         return this.octokitInternal;
     }
 
-
     /**
      * Finds one open `StagingDeployCash` issue via GitHub octokit library.
      *

.github/actions/isPullRequestMergeable/index.js

@@ -140,7 +140,6 @@ class GithubUtils {
         return this.octokitInternal;
     }
 
-
     /**
      * Finds one open `StagingDeployCash` issue via GitHub octokit library.
      *

.github/actions/isStagingDeployLocked/index.js

@@ -103,7 +103,6 @@ class GithubUtils {
         return this.octokitInternal;
     }
 
-
     /**
      * Finds one open `StagingDeployCash` issue via GitHub octokit library.
      *

.github/actions/markPullRequestsAsDeployed/index.js

@@ -272,7 +272,6 @@ class GithubUtils {
         return this.octokitInternal;
     }
 
-
     /**
      * Finds one open `StagingDeployCash` issue via GitHub octokit library.
      *

.github/actions/reopenIssueWithComment/index.js

@@ -114,7 +114,6 @@ class GithubUtils {
         return this.octokitInternal;
     }
 
-
     /**
      * Finds one open `StagingDeployCash` issue via GitHub octokit library.
      *

.github/actions/triggerWorkflowAndWait/index.js

@@ -283,7 +283,6 @@ class GithubUtils {
         return this.octokitInternal;
     }
 
-
     /**
      * Finds one open `StagingDeployCash` issue via GitHub octokit library.
      *

.github/actions/verifySignedCommits/index.js

@@ -103,7 +103,6 @@ class GithubUtils {
         return this.octokitInternal;
     }
 
-
     /**
      * Finds one open `StagingDeployCash` issue via GitHub octokit library.
      *

.github/libs/GithubUtils.js

@@ -63,7 +63,6 @@ class GithubUtils {
         return this.octokitInternal;
     }
 
-
     /**
      * Finds one open `StagingDeployCash` issue via GitHub octokit library.
      *

.github/libs/nativeVersionUpdater.js

@@ -50,7 +50,6 @@ exports.generateAndroidVersionCode = function generateAndroidVersionCode(npmVers
     );
 };
 
-
 /**
  * Update the Android app versionName and versionCode.
  *

assets/emojis.js

@@ -26,7 +26,6 @@ import CONST from '../src/CONST';
  * }
  */
 
-
 // BEFORE YOU EDIT THIS, PLEASE SEE WARNINGS IN EmojiPickerMenu.js
 const skinTones = [{
     code: '🖐',

desktop/main.js

@@ -204,7 +204,6 @@ const mainWindow = (() => {
             appMenu.submenu.insert(1, updateAppMenuItem);
             appMenu.submenu.insert(2, keyboardShortcutsMenu);
 
-
             // On mac, pressing cmd++ actually sends a cmd+=. cmd++ is generally the zoom in shortcut, but this is
             // not properly listened for by electron. Adding in an invisible cmd+= listener fixes this.
             const viewWindow = _.find(systemMenu.items, item => item.role === 'viewmenu');

package.json

@@ -151,7 +151,7 @@
     "electron-notarize": "^1.0.0",
     "electron-reloader": "^1.2.1",
     "eslint": "^7.6.0",
-    "eslint-config-expensify": "2.0.23",
+    "eslint-config-expensify": "^2.0.24",
     "eslint-loader": "^4.0.2",
     "eslint-plugin-jest": "^24.1.0",
     "flipper-plugin-bridgespy-client": "^0.1.9",

src/components/Avatar.js

@@ -8,7 +8,6 @@ import themeColors from '../styles/themes/default';
 import CONST from '../CONST';
 import * as StyleUtils from '../styles/StyleUtils';
 
-
 const propTypes = {
     /** Source for the avatar. Can be a URL or an icon. */
     source: PropTypes.oneOfType([PropTypes.string, PropTypes.func]),

src/components/BigNumberPad.js

@@ -79,7 +79,6 @@ class BigNumberPad extends React.Component {
     }
 }
 
-
 BigNumberPad.propTypes = propTypes;
 
 export default withLocalize(BigNumberPad);

src/components/CheckboxWithLabel.js

@@ -27,7 +27,6 @@ const propTypes = {
     /** Component to display for label */
     LabelComponent: PropTypes.func,
 
-
     /** Error text to display */
     errorText: PropTypes.string,
 

src/components/DisplayNames/index.js

@@ -66,7 +66,6 @@ class DisplayNames extends PureComponent {
         return textNodeRight > containerRight ? -(tooltipX - newToolX) : 0;
     }
 
-
     render() {
         if (!this.props.tooltipEnabled) {
             // No need for any complex text-splitting, just return a simple Text component

src/components/EmojiPicker/EmojiPickerMenu/index.js

@@ -125,7 +125,6 @@ class EmojiPickerMenu extends Component {
         this.setState({selection: event.nativeEvent.selection});
     }
 
-
     /**
      * Setup and attach keypress/mouse handlers for highlight navigation.
      */
@@ -415,7 +414,6 @@ class EmojiPickerMenu extends Component {
             ? types[this.props.preferredSkinTone]
             : code;
 
-
         return (
             <EmojiPickerMenuItem
                 onPress={emoji => this.addToFrequentAndSelectEmoji(emoji, item)}

src/components/EmojiPicker/EmojiPickerMenu/index.native.js

@@ -28,7 +28,6 @@ const propTypes = {
         keywords: PropTypes.arrayOf(PropTypes.string),
     })).isRequired,
 
-
     /** Props related to the dimensions of the window */
     ...windowDimensionsPropTypes,
 
@@ -118,7 +117,6 @@ class EmojiPickerMenu extends Component {
             ? types[this.props.preferredSkinTone]
             : code;
 
-
         return (
             <EmojiPickerMenuItem
                 onPress={emoji => this.addToFrequentAndSelectEmoji(emoji, item)}
@@ -127,7 +125,6 @@ class EmojiPickerMenu extends Component {
         );
     }
 
-
     render() {
         return (
             <View style={styles.emojiPickerContainer}>

src/components/OptionsSelector.js

@@ -170,7 +170,6 @@ class OptionsSelector extends Component {
                     return {focusedIndex: newFocusedIndex};
                 });
 
-
                 e.preventDefault();
                 break;
             }

src/components/Picker/BasePicker/index.js

@@ -25,7 +25,6 @@ const BasePicker = props => (
     />
 );
 
-
 BasePicker.propTypes = basePickerPropTypes.propTypes;
 BasePicker.defaultProps = basePickerPropTypes.defaultProps;
 BasePicker.displayName = 'BasePicker';

src/components/PlaidLink/index.native.js

@@ -4,7 +4,6 @@ import Log from '../../libs/Log';
 import CONST from '../../CONST';
 import {plaidLinkPropTypes, plaidLinkDefaultProps} from './plaidLinkPropTypes';
 
-
 const PlaidLink = (props) => {
     useDeepLinkRedirector();
     usePlaidEmitter((event) => {

src/components/ReportWelcomeText.js

@@ -12,7 +12,6 @@ import * as OptionsListUtils from '../libs/OptionsListUtils';
 import ONYXKEYS from '../ONYXKEYS';
 import CONST from '../CONST';
 
-
 const personalDetailsPropTypes = PropTypes.shape({
     /** The login of the person (either email or phone number) */
     login: PropTypes.string.isRequired,

src/components/TextInput/BaseTextInput.js

@@ -88,7 +88,6 @@ class BaseTextInput extends Component {
         this.appStateSubscription.remove();
     }
 
-
     onPress(event) {
         if (this.props.disabled) {
             return;

src/libs/API.js

@@ -369,7 +369,6 @@ function AddBillingCard(parameters) {
     return Network.post(commandName, parameters, CONST.NETWORK.METHOD.POST, true);
 }
 
-
 /**
  * @param {{password: String, oldPassword: String}} parameters
  * @param {String} parameters.authToken

src/libs/EmojiUtils.js

@@ -122,7 +122,6 @@ function addSpacesToEmojiCategories(emojis) {
     return updatedEmojis;
 }
 
-
 /**
  * Get a merged array with frequently used emojis
  * @param {Object[]} emojis

src/libs/ValidationUtils.js

@@ -294,7 +294,6 @@ function isNumericWithSpecialChars(input) {
     return /^\+?\d*$/.test(LoginUtil.getPhoneNumberWithoutSpecialChars(input));
 }
 
-
 /**
  * Checks the given number is a valid US Routing Number
  * using ABA routingNumber checksum algorithm: http://www.brainjar.com/js/validation/

src/libs/actions/PersonalDetails.js

@@ -75,7 +75,6 @@ function getMaxCharacterError(isError) {
     return isError ? Localize.translateLocal('personalDetails.error.characterLimit', {limit: 50}) : '';
 }
 
-
 /**
  * Format personal details
  *

src/libs/fileDownload/index.native.js

@@ -34,7 +34,6 @@ function hasAndroidPermission() {
     });
 }
 
-
 /**
  * Re useable alert function
  * @param {Object} content
@@ -48,7 +47,6 @@ function showAlert(content) {
     );
 }
 
-
 /**
  * Handling the download
  * @param {String} url
@@ -108,7 +106,6 @@ function handleDownload(url, fileName) {
     });
 }
 
-
 /**
  * Platform specifically check download
  * @param {String} url

src/libs/iOSSafariAutoScrollback/index.web.js

@@ -43,7 +43,6 @@ function scheduleScrollback() {
     }
 }
 
-
 function touchStarted() {
     isTouching = true;
 }
@@ -73,7 +72,6 @@ function stopWaitingForScroll() {
     isWaitingForScroll = false;
 }
 
-
 export default function () {
     if (!getBrowser() === CONST.BROWSER.SAFARI || !Str.contains(userAgent, 'iphone os 1')) {
         return;

src/libs/models/BankAccount.js

@@ -273,7 +273,6 @@ class BankAccount {
         }, this.getAdditionalData());
     }
 
-
     /**
      * Check if user hasn't upgraded their bank account yet.
      * @return {Boolean}

src/pages/ReimbursementAccount/IdentityForm.js

@@ -8,7 +8,6 @@ import CONST from '../../CONST';
 import DatePicker from '../../components/DatePicker';
 import AddressForm from './AddressForm';
 
-
 const propTypes = {
     /** Style for wrapping View */
     style: PropTypes.oneOfType([PropTypes.arrayOf(PropTypes.object), PropTypes.object]),
@@ -64,7 +63,6 @@ const defaultProps = {
     errors: {},
 };
 
-
 const IdentityForm = (props) => {
     // dob field has multiple validations/errors, we are handling it temporarily like this.
     const dobErrorText = (props.errors.dob ? props.translate('bankAccount.error.dob') : '')