[No QA] Upgrade eslint-config-expensify to enable no-multiple-empty-lines rule #8068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
package.json
Outdated
| @@ -151,7 +151,7 @@ | |||
| "electron-notarize": "^1.0.0", | |||
| "electron-reloader": "^1.2.1", | |||
| "eslint": "^7.6.0", | |||
| "eslint-config-expensify": "2.0.23", | |||
| "eslint-config-expensify": "^2.0.24", | |||
There was a problem hiding this comment.
Should we prevent using ^ here? I think if we add new lint rule then it will fail for others if they do fresh npm i, unless all errors are fixed beforehand.
Just my thought. What do you think?
There was a problem hiding this comment.
Oh yeah, good point.
MonilBhavsar
approved these changes
Mar 11, 2022
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
Thank you for fixing this!! |
|
My pleasure. |
52 tasks
|
🚀 Deployed to staging by @MonilBhavsar in version: 1.1.43-0 🚀
|
|
🚀 Deployed to production by @roryabraham in version: 1.1.43-2 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PRs for Expensify/App often have extra unnecessary empty lines.
As a follow up to Expensify/eslint-config-expensify#45, this PR upgrades
eslint-config-expensifytov2.0.24This enables the
no-multiple-empty-linesrule, which will throw a lint error when more than 1 consecutive empty line is used.Reference: https://eslint.org/docs/rules/no-multiple-empty-lines
Fixed Issues
NA
Tests
npm run lintPR Review Checklist
Contributor (PR Author) Checklist
main### Fixed Issuessection abovesrc/languages/*files (if applicable)Styling.md) for all style edits I madeSTYLE.md)Avatar, I verified the components usingAvatarare working as expected)mainbranch)PR Reviewer Checklist
main### Fixed Issuessection abovesrc/languages/*files (if applicable)STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)mainbranch)