Enable no multiple empty lines rule #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, Melvin doesn't seem interested in this repo. @luacmartins could you please give this a review whenever you can (should take 2 mins). |
luacmartins
approved these changes
Mar 10, 2022
|
Thanks, I'm on it |
|
@luacmartins sorry for the trouble, but if I'm not wrong, this needs to be published to npm internally. https://github.com/Expensify/eslint-config-expensify#after-pr-is-merged |
|
Thanks @rushatgabhane! New version is available in npm! |
Merged
49 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
PRs for Expensify/App often have extra unnecessary empty lines.
Some examples - Expensify/App#8059 (comment), Expensify/App#7660 (comment)
Solution
This PR enables the
no-multiple-empty-linesrule, which will throw a lint error when more than 1 consecutive empty line is used.Reference: https://eslint.org/docs/rules/no-multiple-empty-lines