Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[No QA] Upgrade eslint-config-expensify to enable no-multiple-empty-lines rule #8068

Merged
merged 5 commits into from
Mar 11, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/actions/awaitStagingDeploys/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,6 @@ class GithubUtils {
return this.octokitInternal;
}


/**
* Finds one open `StagingDeployCash` issue via GitHub octokit library.
*
Expand Down
1 change: 0 additions & 1 deletion .github/actions/bumpVersion/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,6 @@ exports.generateAndroidVersionCode = function generateAndroidVersionCode(npmVers
);
};


/**
* Update the Android app versionName and versionCode.
*
Expand Down
1 change: 0 additions & 1 deletion .github/actions/checkBundleVersionStringMatch/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,6 @@ exports.generateAndroidVersionCode = function generateAndroidVersionCode(npmVers
);
};


/**
* Update the Android app versionName and versionCode.
*
Expand Down
1 change: 0 additions & 1 deletion .github/actions/checkDeployBlockers/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,6 @@ class GithubUtils {
return this.octokitInternal;
}


/**
* Finds one open `StagingDeployCash` issue via GitHub octokit library.
*
Expand Down
1 change: 0 additions & 1 deletion .github/actions/createOrUpdateStagingDeploy/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -340,7 +340,6 @@ class GithubUtils {
return this.octokitInternal;
}


/**
* Finds one open `StagingDeployCash` issue via GitHub octokit library.
*
Expand Down
1 change: 0 additions & 1 deletion .github/actions/getPullRequestDetails/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,6 @@ class GithubUtils {
return this.octokitInternal;
}


/**
* Finds one open `StagingDeployCash` issue via GitHub octokit library.
*
Expand Down
1 change: 0 additions & 1 deletion .github/actions/getReleaseBody/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,6 @@ class GithubUtils {
return this.octokitInternal;
}


/**
* Finds one open `StagingDeployCash` issue via GitHub octokit library.
*
Expand Down
1 change: 0 additions & 1 deletion .github/actions/isPullRequestMergeable/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,6 @@ class GithubUtils {
return this.octokitInternal;
}


/**
* Finds one open `StagingDeployCash` issue via GitHub octokit library.
*
Expand Down
1 change: 0 additions & 1 deletion .github/actions/isStagingDeployLocked/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,6 @@ class GithubUtils {
return this.octokitInternal;
}


/**
* Finds one open `StagingDeployCash` issue via GitHub octokit library.
*
Expand Down
1 change: 0 additions & 1 deletion .github/actions/markPullRequestsAsDeployed/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,6 @@ class GithubUtils {
return this.octokitInternal;
}


/**
* Finds one open `StagingDeployCash` issue via GitHub octokit library.
*
Expand Down
1 change: 0 additions & 1 deletion .github/actions/reopenIssueWithComment/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,6 @@ class GithubUtils {
return this.octokitInternal;
}


/**
* Finds one open `StagingDeployCash` issue via GitHub octokit library.
*
Expand Down
1 change: 0 additions & 1 deletion .github/actions/triggerWorkflowAndWait/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -283,7 +283,6 @@ class GithubUtils {
return this.octokitInternal;
}


/**
* Finds one open `StagingDeployCash` issue via GitHub octokit library.
*
Expand Down
1 change: 0 additions & 1 deletion .github/actions/verifySignedCommits/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,6 @@ class GithubUtils {
return this.octokitInternal;
}


/**
* Finds one open `StagingDeployCash` issue via GitHub octokit library.
*
Expand Down
1 change: 0 additions & 1 deletion .github/libs/GithubUtils.js
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,6 @@ class GithubUtils {
return this.octokitInternal;
}


/**
* Finds one open `StagingDeployCash` issue via GitHub octokit library.
*
Expand Down
1 change: 0 additions & 1 deletion .github/libs/nativeVersionUpdater.js
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@ exports.generateAndroidVersionCode = function generateAndroidVersionCode(npmVers
);
};


/**
* Update the Android app versionName and versionCode.
*
Expand Down
1 change: 0 additions & 1 deletion assets/emojis.js
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ import CONST from '../src/CONST';
* }
*/


// BEFORE YOU EDIT THIS, PLEASE SEE WARNINGS IN EmojiPickerMenu.js
const skinTones = [{
code: '🖐',
Expand Down
1 change: 0 additions & 1 deletion desktop/main.js
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,6 @@ const mainWindow = (() => {
appMenu.submenu.insert(1, updateAppMenuItem);
appMenu.submenu.insert(2, keyboardShortcutsMenu);


// On mac, pressing cmd++ actually sends a cmd+=. cmd++ is generally the zoom in shortcut, but this is
// not properly listened for by electron. Adding in an invisible cmd+= listener fixes this.
const viewWindow = _.find(systemMenu.items, item => item.role === 'viewmenu');
Expand Down
18 changes: 9 additions & 9 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@
"electron-notarize": "^1.0.0",
"electron-reloader": "^1.2.1",
"eslint": "^7.6.0",
"eslint-config-expensify": "2.0.23",
"eslint-config-expensify": "2.0.24",
"eslint-loader": "^4.0.2",
"eslint-plugin-jest": "^24.1.0",
"flipper-plugin-bridgespy-client": "^0.1.9",
Expand Down
1 change: 0 additions & 1 deletion src/components/Avatar.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import themeColors from '../styles/themes/default';
import CONST from '../CONST';
import * as StyleUtils from '../styles/StyleUtils';


const propTypes = {
/** Source for the avatar. Can be a URL or an icon. */
source: PropTypes.oneOfType([PropTypes.string, PropTypes.func]),
Expand Down
1 change: 0 additions & 1 deletion src/components/BigNumberPad.js
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,6 @@ class BigNumberPad extends React.Component {
}
}


BigNumberPad.propTypes = propTypes;

export default withLocalize(BigNumberPad);
1 change: 0 additions & 1 deletion src/components/CheckboxWithLabel.js
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ const propTypes = {
/** Component to display for label */
LabelComponent: PropTypes.func,


/** Error text to display */
errorText: PropTypes.string,

Expand Down
1 change: 0 additions & 1 deletion src/components/DisplayNames/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,6 @@ class DisplayNames extends PureComponent {
return textNodeRight > containerRight ? -(tooltipX - newToolX) : 0;
}


render() {
if (!this.props.tooltipEnabled) {
// No need for any complex text-splitting, just return a simple Text component
Expand Down
2 changes: 0 additions & 2 deletions src/components/EmojiPicker/EmojiPickerMenu/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,6 @@ class EmojiPickerMenu extends Component {
this.setState({selection: event.nativeEvent.selection});
}


/**
* Setup and attach keypress/mouse handlers for highlight navigation.
*/
Expand Down Expand Up @@ -415,7 +414,6 @@ class EmojiPickerMenu extends Component {
? types[this.props.preferredSkinTone]
: code;


return (
<EmojiPickerMenuItem
onPress={emoji => this.addToFrequentAndSelectEmoji(emoji, item)}
Expand Down
3 changes: 0 additions & 3 deletions src/components/EmojiPicker/EmojiPickerMenu/index.native.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ const propTypes = {
keywords: PropTypes.arrayOf(PropTypes.string),
})).isRequired,


/** Props related to the dimensions of the window */
...windowDimensionsPropTypes,

Expand Down Expand Up @@ -118,7 +117,6 @@ class EmojiPickerMenu extends Component {
? types[this.props.preferredSkinTone]
: code;


return (
<EmojiPickerMenuItem
onPress={emoji => this.addToFrequentAndSelectEmoji(emoji, item)}
Expand All @@ -127,7 +125,6 @@ class EmojiPickerMenu extends Component {
);
}


render() {
return (
<View style={styles.emojiPickerContainer}>
Expand Down
1 change: 0 additions & 1 deletion src/components/OptionsSelector.js
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,6 @@ class OptionsSelector extends Component {
return {focusedIndex: newFocusedIndex};
});


e.preventDefault();
break;
}
Expand Down
1 change: 0 additions & 1 deletion src/components/Picker/BasePicker/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ const BasePicker = props => (
/>
);


BasePicker.propTypes = basePickerPropTypes.propTypes;
BasePicker.defaultProps = basePickerPropTypes.defaultProps;
BasePicker.displayName = 'BasePicker';
Expand Down
1 change: 0 additions & 1 deletion src/components/PlaidLink/index.native.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import Log from '../../libs/Log';
import CONST from '../../CONST';
import {plaidLinkPropTypes, plaidLinkDefaultProps} from './plaidLinkPropTypes';


const PlaidLink = (props) => {
useDeepLinkRedirector();
usePlaidEmitter((event) => {
Expand Down
1 change: 0 additions & 1 deletion src/components/ReportWelcomeText.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ import * as OptionsListUtils from '../libs/OptionsListUtils';
import ONYXKEYS from '../ONYXKEYS';
import CONST from '../CONST';


const personalDetailsPropTypes = PropTypes.shape({
/** The login of the person (either email or phone number) */
login: PropTypes.string.isRequired,
Expand Down
1 change: 0 additions & 1 deletion src/components/TextInput/BaseTextInput.js
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,6 @@ class BaseTextInput extends Component {
this.appStateSubscription.remove();
}


onPress(event) {
if (this.props.disabled) {
return;
Expand Down
1 change: 0 additions & 1 deletion src/libs/API.js
Original file line number Diff line number Diff line change
Expand Up @@ -369,7 +369,6 @@ function AddBillingCard(parameters) {
return Network.post(commandName, parameters, CONST.NETWORK.METHOD.POST, true);
}


/**
* @param {{password: String, oldPassword: String}} parameters
* @param {String} parameters.authToken
Expand Down
1 change: 0 additions & 1 deletion src/libs/EmojiUtils.js
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,6 @@ function addSpacesToEmojiCategories(emojis) {
return updatedEmojis;
}


/**
* Get a merged array with frequently used emojis
* @param {Object[]} emojis
Expand Down
1 change: 0 additions & 1 deletion src/libs/ValidationUtils.js
Original file line number Diff line number Diff line change
Expand Up @@ -294,7 +294,6 @@ function isNumericWithSpecialChars(input) {
return /^\+?\d*$/.test(LoginUtil.getPhoneNumberWithoutSpecialChars(input));
}


/**
* Checks the given number is a valid US Routing Number
* using ABA routingNumber checksum algorithm: http://www.brainjar.com/js/validation/
Expand Down
1 change: 0 additions & 1 deletion src/libs/actions/PersonalDetails.js
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,6 @@ function getMaxCharacterError(isError) {
return isError ? Localize.translateLocal('personalDetails.error.characterLimit', {limit: 50}) : '';
}


/**
* Format personal details
*
Expand Down
3 changes: 0 additions & 3 deletions src/libs/fileDownload/index.native.js
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ function hasAndroidPermission() {
});
}


/**
* Re useable alert function
* @param {Object} content
Expand All @@ -48,7 +47,6 @@ function showAlert(content) {
);
}


/**
* Handling the download
* @param {String} url
Expand Down Expand Up @@ -108,7 +106,6 @@ function handleDownload(url, fileName) {
});
}


/**
* Platform specifically check download
* @param {String} url
Expand Down
2 changes: 0 additions & 2 deletions src/libs/iOSSafariAutoScrollback/index.web.js
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@ function scheduleScrollback() {
}
}


function touchStarted() {
isTouching = true;
}
Expand Down Expand Up @@ -73,7 +72,6 @@ function stopWaitingForScroll() {
isWaitingForScroll = false;
}


export default function () {
if (!getBrowser() === CONST.BROWSER.SAFARI || !Str.contains(userAgent, 'iphone os 1')) {
return;
Expand Down
1 change: 0 additions & 1 deletion src/libs/models/BankAccount.js
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,6 @@ class BankAccount {
}, this.getAdditionalData());
}


/**
* Check if user hasn't upgraded their bank account yet.
* @return {Boolean}
Expand Down
2 changes: 0 additions & 2 deletions src/pages/ReimbursementAccount/IdentityForm.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import CONST from '../../CONST';
import DatePicker from '../../components/DatePicker';
import AddressForm from './AddressForm';


const propTypes = {
/** Style for wrapping View */
style: PropTypes.oneOfType([PropTypes.arrayOf(PropTypes.object), PropTypes.object]),
Expand Down Expand Up @@ -64,7 +63,6 @@ const defaultProps = {
errors: {},
};


const IdentityForm = (props) => {
// dob field has multiple validations/errors, we are handling it temporarily like this.
const dobErrorText = (props.errors.dob ? props.translate('bankAccount.error.dob') : '')
Expand Down
Loading