-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Android build variables to env #9120
Conversation
|
@AndrewGable feel free to merge this. Wanted to wait till you were online so you could verify the build went successfully yourself. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, we don't need these environment variables for the deliver step (aka production deploys) because the app is already built and uploaded?
Yes - Correct. I confirmed that they are not used in that step in the |
Move Android build variables to env (cherry picked from commit a337f97)
…9120 🍒 Cherry pick PR #9120 to staging 🍒
🚀 Cherry-picked to staging by @AndrewGable in version: 1.1.73-1 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
🚀 Deployed to production by @yuwenmemon in version: 1.1.73-2 🚀
|
Details
Removes the Android keystore and key alias passwords to environment variables to lock things down 🔐
Keystore and key password were rotated internally ♻️
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/209628
Tests